Sauli Tähkäpää comments

Results 61 comments of


                                            Sauli Tähkäpää

Add mix-ins to allow external styling of data-table-cell elements

No problem at all, glad you got it working! 👍🏻

FR: warning when clear selection due to filter/sort

Hi! This is actually by design – the challenge is that we're comparing the item objects to determine if they're selected or not and the assumption is that when filtering/sorting...

Add CSS variables for cell height

Hi! Please see my comment here: https://github.com/Saulis/iron-data-table/pull/147#issuecomment-268235072

Hidden property is not being passed correctly from data-table-column to data-table-cell

Hi! I think the problem here might actually be the parent property `columnHideMatch` you're using, it's not handled correctly in the cells. It's a more general issue I need to...

Hidden property is not being passed correctly from data-table-column to data-table-cell

hmm.. strange. Can you make the problem reproduce itself by modifying this snippet: http://jsbin.com/pubole/1/edit?html,output ?

Maximun call stack size exceeded while hidding columns

Thanks for the report! Can you verify if branch `notify-resize-on-hidden` works better for you?

Maximun call stack size exceeded while hidding columns

Hmm strange, can't seem to get the error to appear. Could you modify this snippet so that it reproduces the error? http://jsbin.com/murayi/edit?html,output

Maximun call stack size exceeded while hidding columns

@robinroyer btw, why are you hiding all the columns instead of the table element?

Maximun call stack size exceeded while hidding columns

OK, I've added a new commit to the same branch that should prevent call stack error from happening.

Maximun call stack size exceeded while hidding columns

@robinroyer any progress on this?