pydqc icon indicating copy to clipboard operation
pydqc copied to clipboard

Add parameters table1_name,table2_name in data_compare method.

Open anilkumarpanda opened this issue 4 years ago • 2 comments

Current implementation of data_compare assigns default values of 'table1' and 'table2' to the dataframes.

image

However, it would be good if the user can specify name of the dataframe, to be able to distinguish the dataframes better.

The signature can be as follows: distribution_compare_pretty(_df1, _df2, _df1_name='table1',_df2_name='table2', col, figsize=None, date_flag=False)

anilkumarpanda avatar Apr 12 '20 14:04 anilkumarpanda

I would be happy to make the changes, if you agree.

anilkumarpanda avatar Apr 12 '20 14:04 anilkumarpanda

Yes, please help create a PR and everyone can use the same function.

2020年4月12日(日) 午後10:40 Anilkumar Panda [email protected]:

I would be happy to make the changes, if you agree.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SauceCat/pydqc/issues/23#issuecomment-612626053, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXNPFFKLIUJCT6SX6WQTBLRMHHFXANCNFSM4MGN6LSQ .

SauceCat avatar Apr 12 '20 14:04 SauceCat