Spring-Music-Player
Spring-Music-Player copied to clipboard
Fixed Navbar centering & search input/button styling
Description
A clear and concise description of what the PR does.
- This PR does the following:
- Fixes NavBar (previously sidebar) and search button and search input in Navbar
- Updates Sidebar, making it responsive and fixes search field.
Related Issues
Fixes #135
Changes
List the detailed changes made in this PR.
- Added new icons as svg components in newly created Assets folder
- Refactored unnecessary styling in App.css with new changes.
Screenshots (if applicable)
Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings
- [x] I am working on this issue under GSSOC
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| spring-music-player | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 31, 2024 8:05am |
| spring-music-player-3hyj | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 31, 2024 8:05am |
@The-Phoenics is attempting to deploy a commit to the satyam1923's projects Team on Vercel.
A member of the Team first needs to authorize it.
Hi @Satyam1923, I've made necessary changes to the NavBar and search field styling. I've also updated the nav icons to match those in the provided design file. Can you review my PR?
@The-Phoenics Can u give a preview of the changes in video format. Make suru in every device screen view the responsiveness never affect.
Here's the video @saurabhsingh720, https://github.com/Satyam1923/Spring-Music-Player/assets/96228962/47836e05-6413-4bc6-8fbc-c454780217bd
Here's the video @saurabhsingh720, https://github.com/Satyam1923/Spring-Music-Player/assets/96228962/47836e05-6413-4bc6-8fbc-c454780217bd
Text is overflowing
Here's the video @saurabhsingh720, https://github.com/Satyam1923/Spring-Music-Player/assets/96228962/47836e05-6413-4bc6-8fbc-c454780217bd
Text is overflowing
If you mean text within centre and the right section of page. Then that wasn't the goal of this PR and it's corresponding issue, it should be fixed with a separate Issue and PR.
Hey @Satyam1923,
I haven't received any response on this PR; it's been more than a week now. Could you merge this PR until the new design is ready, or if it's not valid, could we close it?