Saturn icon indicating copy to clipboard operation
Saturn copied to clipboard

Published 20 hours ago • verified publisher icon SaturnFramework

Cherry-Pick: #270 fix to v0.14

Open kevingentile opened this issue 4 years ago • 3 comments
trafficstars

Currently not in a position to upgrade to netcoreapp 5.0 and require this fix for v14

This branch was based off tag v0.14.1

kevingentile avatar Aug 11 '21 18:08 kevingentile

#270 got already closed in 2020. Is this issue still open?

tforkmann avatar Jan 15 '22 14:01 tforkmann

I'm inclined not to do this. @kevingentile how are you planning to consume this fix in v0.14, build from source? There's no way to back-port it to that release in NuGet.

cartermp avatar Jan 15 '22 16:01 cartermp

@cartermp Thank you for your time. A v0.14.2 would be sufficient.

The framework change from netcoreapp3.1 in v0.14 to net5.0 in v0.15 was a breaking change. Consumers with similar limitations will always own this bug.

Workaround is to implement and use a local copy of UseGZip with 8e27614 to re-enable JSON compression.

EDIT: Looking at the build workflow at v0.14.1, you would need a protected v0.14.x branch at v0.14.1 to base this PR. Then a tag and push v0.14.2 after merging.

kevingentile avatar Jan 15 '22 22:01 kevingentile