cyphernode icon indicating copy to clipboard operation
cyphernode copied to clipboard

Add getmininginfo call

Open BHodl opened this issue 4 years ago • 7 comments

Let me know if I miss something. Not tested!

BHodl avatar Aug 23 '21 23:08 BHodl

The getmininginfo call tested and working. The getblockhashps call don't pass the gatekeeper. Maybe related to api.properties, wip.

BHodl avatar Aug 26 '21 09:08 BHodl

Fixed but.. Currently getblockhashps with optional blockheight not returning the right hashps. Let wait the node is fully synced to see... Maybe we shoudl add a send_to_stats_node function for that kind of call, not including wallet specifics.

BHodl avatar Aug 26 '21 18:08 BHodl

Thanks and sorry for the delay, have been particularly busy lately.

Did you get a chance to make it work?

Kexkey avatar Sep 01 '21 19:09 Kexkey

Yeah! No problemo, we all want to see lnurl stuff in cyphernode, keep up the good work! The getmininginfo is working perfectly, but things need to be modified for the getblockhashps. I will probably change the call name for getnetworkhashps to be consistent with bitcoincore call, and modify the returned data. I wait my cyphernode to be fully sync to test that one. I will confirm when fully tested.

BHodl avatar Sep 01 '21 19:09 BHodl

Fully tested and working! It's my first PR so let me know if I miss something. I'm mostly setup for testing changes now, next time I will probably do my coding and testing before pushing the PR. One thing that can be improved is adding a send_to_stats_node function in sendtobitcoinnode.sh not including wallets specifics for stats call. But since it's affect all stats call, a separate PR would be better. Let me know what you think!

BHodl avatar Sep 08 '21 13:09 BHodl

Updated to solve v0.8.0 conflicts. Tested and working.

BHodl avatar Mar 22 '22 21:03 BHodl

Rebase on dev, thanks!

Kexkey avatar Mar 24 '22 18:03 Kexkey