boltz-rust icon indicating copy to clipboard operation
boltz-rust copied to clipboard
verified publisher icon SatoshiPortal

Add missing SubSwapStates and rustdocs for each state

Open ok300 opened this issue 1 year ago • 5 comments

Based on some previous work from @hydra-yse , I added the missing RevSwapStates.

I also included descriptions for each submarine and reverse swap state from the Boltz Docs.

ok300 avatar May 17 '24 17:05 ok300

I'm not sure why the test is failing, but it's not related to this PR.

ok300 avatar May 17 '24 17:05 ok300

Since the PR is related to model fields, I added a commit on making all fields of CreateSubmarineResponse public, so they can be read by callers.

ok300 avatar May 21 '24 06:05 ok300

Thanks @michael1011 , I applied your changes.

ok300 avatar May 21 '24 10:05 ok300

Thanks @ok300 !

The failing test is not related to this PR indeed. I will patch it after merging.

i5hi avatar May 21 '24 19:05 i5hi

Concept ACK.

i5hi avatar May 21 '24 19:05 i5hi