spotify-dl icon indicating copy to clipboard operation
spotify-dl copied to clipboard

the --version flag should work alone

Open michaelkarlcoleman opened this issue 3 years ago • 2 comments

The --version flag should work even if no other flags are given.

$ spotify_dl --version
usage: spotify_dl [-h] -l URL -o OUTPUT [-d] [-f FORMAT_STR] [-k] [-m] [-s SCRAPE] [-V] [-v]
spotify_dl: error: the following arguments are required: -l/--url, -o/--output

michaelkarlcoleman avatar Jul 04 '21 23:07 michaelkarlcoleman

yeah, that's a catch with ArgParser. With the most recent update, spotify-dl prints teh version on startup so I will be removing this flag

SathyaBhat avatar Jul 06 '21 18:07 SathyaBhat

Ah, I see where you're going. It's likely too picayune to say, but arguably --output could just default to the current working directory and --url could be the (sole) positional argument.

In any case, it's working well for me, and this is my nomination for "Project of the Year"!

michaelkarlcoleman avatar Jul 06 '21 21:07 michaelkarlcoleman

This is fixed as of v8.4.0 https://github.com/SathyaBhat/spotify-dl/discussions/307

SathyaBhat avatar Oct 30 '22 01:10 SathyaBhat