robottelo icon indicating copy to clipboard operation
robottelo copied to clipboard

Fix upstream api permission tests

Open dosas opened this issue 11 months ago • 1 comments

Problem Statement

API permission tests failing for upstream

Solution

  • add more checks for installed rpm packages
  • speedup by querying rpm -qa ony once
  • some tests were not updated with this commit https://github.com/SatelliteQE/robottelo/commit/6651dd63b4c308b3f7f3601f0e69d76b4c602b29#diff-9a55ae74469aa91ad5efb2b9068f73174467cd0c00d45abf7d35f9f2277a7632

Relevant tests:

tests/foreman/cli/test_role.py
tests/foreman/api/test_role.py
tests/foreman/api/test_permission.py

dosas avatar Mar 21 '24 14:03 dosas

@pondrejk @lhellebr @pnovotny Can you please take a look at @dosas's PR? It is touching a module that belongs to your team.

ogajduse avatar Apr 02 '24 17:04 ogajduse

trigger: test-robottelo pytest: tests/foreman/api/test_permission.py -k test_positive_search

pondrejk avatar Apr 17 '24 07:04 pondrejk

PRT Result

Build Number: 6545
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_permission.py -k test_positive_search --external-logging
Test Result : ========== 3 passed, 13 deselected, 114 warnings in 812.58s (0:13:32) ==========

Satellite-QE avatar Apr 17 '24 08:04 Satellite-QE

@pondrejk Why did you remove the labels?

dosas avatar Apr 17 '24 08:04 dosas

hi @dosas, I checked out this branch locally and ran some tests from the affected files, all seems well, prt also passes so I'm ok with merging this, thanks for the contribution. I reckoned that downstream branches would not be of interest to you, so I changed the labels. If you need those cherry picks I can put them back

pondrejk avatar Apr 17 '24 09:04 pondrejk

hi @dosas, I checked out this branch locally and ran some tests from the affected files, all seems well, prt also passes so I'm ok with merging this, thanks for the contribution. I reckoned that downstream branches would not be of interest to you, so I changed the labels. If you need those cherry picks I can put them back

I would require 6.15.z please

dosas avatar Apr 17 '24 09:04 dosas