robottelo icon indicating copy to clipboard operation
robottelo copied to clipboard

[6.13.z] - remove the all nailgun imports from UI folder

Open omkarkhatavkar opened this issue 11 months ago • 7 comments

Problem Statement

We are using the direct imports from the nailgun rather than directly using from target_sat

Solution

Direct Imports Removed: We've cleaned up our codebase by eliminating direct imports from the Nailgun package.

Using target_sat, module_target_sat, class_target_sat: Modified the API calls and using the target_sat.api. pattern for all API calls.

omkarkhatavkar avatar Mar 18 '24 12:03 omkarkhatavkar

trigger: test-robottelo pytest: tests/foreman/ui/ -m e2e

omkarkhatavkar avatar Mar 18 '24 12:03 omkarkhatavkar

PRT Result

Build Number: 6100
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/ -m e2e --external-logging
Test Result : = 2 failed, 12 passed, 777 deselected, 908 warnings, 10 errors in 6101.76s (1:41:41) =

Satellite-QE avatar Mar 18 '24 14:03 Satellite-QE

trigger: test-robottelo pytest: tests/foreman/ui/

Gauravtalreja1 avatar Mar 22 '24 19:03 Gauravtalreja1

PRT Result

Build Number: 6174
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/ --external-logging
Test Result : = 203 failed, 433 passed, 23 skipped, 57 deselected, 11995 warnings, 88 errors in 94713.20s (1 day, 2:18:33) =

Satellite-QE avatar Mar 23 '24 21:03 Satellite-QE

@omkarkhatavkar Could you rebase and update this PR?

Gauravtalreja1 avatar Apr 11 '24 10:04 Gauravtalreja1

@Gauravtalreja1 @jyejare Rebase Done !

omkarkhatavkar avatar Apr 15 '24 05:04 omkarkhatavkar

@omkarkhatavkar Could you rebase this PR again?

Gauravtalreja1 avatar May 15 '24 09:05 Gauravtalreja1

@Gauravtalreja1 @Gauravtalreja1 @pondrejk can we merge this ?

omkarkhatavkar avatar Jun 07 '24 11:06 omkarkhatavkar

ACK

pnovotny avatar Jun 07 '24 21:06 pnovotny