robottelo icon indicating copy to clipboard operation
robottelo copied to clipboard

First Ansible Roles API test

Open sambible opened this issue 2 years ago • 2 comments

Requires https://github.com/SatelliteQE/nailgun/pull/841

First test surrounding Ansible Roles

sambible avatar Sep 29 '22 21:09 sambible

trigger: test-robottelo pytest: tests/foreman/api/test_ansible.py -k 'test_positive_assign_ansible_role' nailgun: 841

Griffin-Sullivan avatar Sep 30 '22 12:09 Griffin-Sullivan

trigger: test-robottelo pytest: tests/foreman/api/test_ansible.py -k 'test_positive_assign_ansible_role' nailgun: 841

sambible avatar Sep 30 '22 14:09 sambible

@sambible any updates on this PR?

adarshdubey-star avatar Nov 18 '22 13:11 adarshdubey-star

trigger: test-robottelo pytest: tests/foreman/api/test_ansible.py -k 'test_positive_assign_ansible_role' nailgun: 841

Gauravtalreja1 avatar Dec 02 '22 17:12 Gauravtalreja1

Addressed comments and implemented @ogajduse change request. Going to run the test again with runner, but should be good to go when we can merge the Nailgun PR

sambible avatar Dec 12 '22 20:12 sambible

trigger: test-robottelo pytest: tests/foreman/api/test_ansible.py -k 'test_positive_assign_ansible_role' nailgun: 841

adarshdubey-star avatar Dec 13 '22 17:12 adarshdubey-star

trigger: test-robottelo pytest: tests/foreman/api/test_ansible.py -k 'test_positive_assign_ansible_role' nailgun: 841

sambible avatar Dec 13 '22 18:12 sambible

trigger: test-robottelo pytest: tests/foreman/api/test_ansible.py -k 'test_positive_assign_ansible_role' nailgun: 841

devendra104 avatar Dec 13 '22 18:12 devendra104

trigger: test-robottelo pytest: tests/foreman/api/test_ansible.py -k 'test_positive_assign_ansible_role' nailgun: 841

omkarkhatavkar avatar Dec 14 '22 05:12 omkarkhatavkar

Nailgun PR is merged, this can go In now.

sambible avatar Jan 16 '23 19:01 sambible

@sambible rebase and we can merge!

Griffin-Sullivan avatar Jan 25 '23 17:01 Griffin-Sullivan

I guess we need to rebase again

Griffin-Sullivan avatar Feb 08 '23 15:02 Griffin-Sullivan

trigger: test-robottelo pytest: tests/foreman/api/test_ansible.py -k 'test_positive_assign_ansible_role'

sambible avatar Feb 22 '23 21:02 sambible

@sambible Can you check on the PRT failure and revisit this PR? It would be nice to have this merged.

JacobCallahan avatar Mar 14 '23 13:03 JacobCallahan

I vote we just close this PR as tests/foreman/api/test_ansible.py::test_positive_ansible_job_on_host has already covered what this test is doing. There are also equivalent tests in CLI and UI now, so I don't see the need to keep this test when it is already set up for those other tests.

Griffin-Sullivan avatar Apr 10 '23 13:04 Griffin-Sullivan