robottelo icon indicating copy to clipboard operation
robottelo copied to clipboard

Utility Helper Modules moving to utils

Open jyejare opened this issue 3 years ago • 4 comments

As part of the helpers refactor for aligning the helper's modules in right place, the following Utility Helper modules are moving under the utils module:

  • ssh.py (changing importing of robottelo.ssh to robottelo.utils.ssh)
  • decorators package (changing importing of robottelo.decorators to robottelo.utils.decorators)
  • datafactory.py (changing importing of robottelo.datafactory to robottelo.utils.datafactory)
  • virtwho_utils.py (changing importing of robottelo.virtwho_utils to robottelo.utils.virtwho_utils)

Renamed Module:

  • errors.py to exceptions.py (changing importing of robottelo.errors to robottelo.utils.exceptions)

jyejare avatar Sep 14 '22 10:09 jyejare

@SatelliteQE/robottelo-tier-1-reviewers @SatelliteQE/robottelo-tier-2-reviewers Please review.

jyejare avatar Sep 29 '22 16:09 jyejare

@SatelliteQE/tier-1-reviewers and @SatelliteQE/tier-2-reviewers please review! Its long pending !

jyejare avatar Oct 10 '22 15:10 jyejare

@JacobCallahan I dont see @yanpliu 's comment as of yet ! But TBH its not critical feedback to wait for her comment, I can do in this PR as well.

jyejare avatar Oct 17 '22 13:10 jyejare

@jyejare Please fix this occurrence as well, robottelo-ci is failing in test-collection with,

/opt/hostedtoolcache/Python/3.8.14/x64/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/foreman/virtwho/cli/test_nutanix.py:23: in <module>
    from robottelo.virtwho_utils import deploy_configure_by_command
E   ModuleNotFoundError: No module named 'robottelo.virtwho_utils'
=========================== short test summary info ============================

Gauravtalreja1 avatar Oct 21 '22 10:10 Gauravtalreja1