airgun icon indicating copy to clipboard operation
airgun copied to clipboard

Sync Status page does not display correctly unless refreshed

Open swadeley opened this issue 4 years ago • 4 comments

Hello

Sync Status page does not display correctly unless refreshed. The clickable expander triangles aren't visible and test[1] fails when trying to open them.

This issue affect 6.7.2 and 6.7.3 snap 1 but not 6.8 snap 12

image

The test I am running[1] fails here:

session.organization.select(org_name=module_org_with_manifest.name)
  >           results = session.sync_status.synchronize(repo_paths)

tests/foreman/ui/test_sync.py:110:

underlying error is here:

   >               'Adding node to a non section one is prohibited')
 E           airgun.views.sync_status.ReservedToSectionOnlyError: Adding
 node to a non section one is prohibited

 ./airgun/views/sync_status.py:133:
 ReservedToSectionOnlyError

Adding view.browser.refresh() fixes the issue:

airgun/entities/sync_status.py:

    view = self.navigate_to(self, 'All')
    view.browser.refresh()
    repo_nodes = [view.table.get_node_from_path(repo_path)
                  for repo_path in repository_paths]

Thanks to Tasos Papaioannou for the suggestion.

Using Chromium Version 84.0.4147.89 (Developer Build) Fedora Project (64-bit)

[1] https://github.com/SatelliteQE/robottelo/blob/abf74da078eaacbecc7a2e8e5e9a1e809eeaafc4/tests/foreman/ui/test_sync.py#L82

swadeley avatar Aug 26 '20 15:08 swadeley

Isn't that regression that should be also fixed downstream?

I'm fine with workarounds being present until product fix their bugs, but we shouldn't keep them much longer than necessary. Having bz number in github issue and commit message will hopefully make it a little clearer this is something we can revert eventually.

mirekdlugosz avatar Aug 26 '20 16:08 mirekdlugosz

Isn't that regression that should be also fixed downstream?

I'm fine with workarounds being present until product fix their bugs, but we shouldn't keep them much longer than necessary. Having bz number in github issue and commit message will hopefully make it a little clearer this is something we can revert eventually.

Unfortunately we cannot reproduce the error except by running the test. So there is no evidence a user would encounter this and a bug without a reproducer, other than our tests, is not good. I did ask devs to consider what might cause this.

Now that we know Sat6.8 is not affected its seems to be the opposite of a regression to me.

Thank you

swadeley avatar Aug 26 '20 18:08 swadeley

Unfortunately we cannot reproduce the error except by running the test.

Could it be that test tries to perform action too quickly, and failure could be fixed by waiting a little longer rather than refreshing page?

Now that we know Sat6.8 is not affected its seems to be the opposite of a regression to me.

The way I read "This issue affect 6.7.2 and 6.7.3 snap 1" from initial message, is that it started to appear in 6.7.2 - i.e. 6.7.1 and 6.7 were fine. But maybe I'm jumping to conclusion here, you meant that you confirmed that on 6.7.2 and 6.7.3, but we have no information about earlier 6.7 releases.

mirekdlugosz avatar Aug 27 '20 10:08 mirekdlugosz

Unfortunately we cannot reproduce the error except by running the test.

Could it be that test tries to perform action too quickly, and failure could be fixed by waiting a little longer rather than refreshing page?

That was suggested by others and I did check for that, but waiting does not help.

Now that we know Sat6.8 is not affected its seems to be the opposite of a regression to me.

The way I read "This issue affect 6.7.2 and 6.7.3 snap 1" from initial message, is that it started to appear in 6.7.2 - i.e. 6.7.1 and 6.7 were fine. But maybe I'm jumping to conclusion here, you meant that you confirmed that on 6.7.2 and 6.7.3, but we have no information about earlier 6.7 releases.

  • I have not tested with releases before 6.7.2
  • I tested on 6.7.2 and 6.7.3 snap 1, and the both had this issue
  • I tested on Sat6.8 snap 12 and it does not have this issue

swadeley avatar Aug 27 '20 13:08 swadeley