sassdoc icon indicating copy to clipboard operation
sassdoc copied to clipboard

Prevent duplicate entries in requirements

Open reneroth opened this issue 7 years ago • 7 comments

Fixes issue #530 :)

reneroth avatar Nov 07 '18 20:11 reneroth

Coverage Status

Coverage increased (+0.01%) to 94.69% when pulling 7bb4ce867bedcf72afad7c8fca4a0c9a9c118e45 on reneroth:fix/dependency-duplication into c80a23f05ae9da4990d417f18d3b2f45dbaf0ec3 on SassDoc:master.

coveralls avatar Nov 07 '18 20:11 coveralls

This would be very helpful for my team - is there any way I can help to get this PR merged and a release rolled with it?

castastrophe avatar Feb 02 '21 15:02 castastrophe

@castastrophe Hello, yes, we would like a few unit tests added to assert the behavior/change works as intended and prevent later regressions.

Don't hesitate to ask if you need guidance.

pascalduez avatar Feb 03 '21 10:02 pascalduez

  • [ ] @castastrophe to add unit tests

[adding this as a reminder to myself to pick this up]

castastrophe avatar Jun 28 '21 17:06 castastrophe

👀

reneroth avatar Aug 03 '22 05:08 reneroth

@reneroth Sorry about this - I committed to doing this and promptly started a new job and have been doing some intense onboarding. I'll see if I can get back into this at some point in the near future but also open to anyone else picking it up if they like.

castastrophe avatar Aug 06 '22 18:08 castastrophe

@reneroth Sorry about this - I committed to doing this and promptly started a new job and have been doing some intense onboarding. I'll see if I can get back into this at some point in the near future but also open to anyone else picking it up if they like.

Haha no worries friend! I just stumbled across this when reviewing my open pull requests, completely forgot about it :D

reneroth avatar Aug 07 '22 10:08 reneroth

Closing this PR for selfish reasons because I want an "inbox zero" kind of feeling for my PR list.
Code is functional if anyone still needs it.

reneroth avatar Jun 27 '23 09:06 reneroth