sassdoc icon indicating copy to clipboard operation
sassdoc copied to clipboard

Missing Bitbucket support for 'basePath' option

Open trollsyn opened this issue 8 years ago • 4 comments
trafficstars

This problem appears when you use a Bitbucket repo in your basePath option, and try to navigate to a source file with line number highlighting.

Examples for the 'basePath' option:

  • https://github.com/username/repo-name/blob/master/some-folder
  • https://bitbucket.org/username/repo-name/src/master/some-folder

This is how Github highlights line numbers: ../my-file.scss#L13-L37

This is how Bitbucket highlights line numbers: ../my-file.scss?at=master&fileviewer=file-view-default#my-file.scss-13:37

It works like a charm when pointing to a Github repo, but not when using Bitbucket.

This is perhaps a feature request, but it would be very nice to have the same functionality in both worlds.

Thanks for the awesomeness!

trollsyn avatar Jan 03 '17 09:01 trollsyn

Why not adding it, although this feels really breakage prone, all the params.

pascalduez avatar Jan 03 '17 11:01 pascalduez

On bitbucket-server v4.12.1 I'm seeing a different set of params.

I have: app/styles/_colors.scss#13-37 vs. app/styles/_colors.scss?at=master&fileviewer=file-view-default#_colors.scss-13:37

?at=master&fileviewer=file-view-default goes largely ignored as far as I see, however the line number syntax doesn't work.

gearsandcode avatar Jan 21 '17 02:01 gearsandcode

Any word on this @pascalduez ?

gearsandcode avatar Feb 01 '17 17:02 gearsandcode

Well your last comment is not really motivating :)
The fact to have several possible params, and that they could change at any time.

Also that would mean a new config key somehow, to switch source etc.

pascalduez avatar Feb 01 '17 17:02 pascalduez