Saransh Chopra

Results 169 comments of Saransh Chopra

Also, now that I look at it, maybe we should always use the old logo in README? Flux uses the old logo everywhere (for example - FluxML's GitHub logo/display picture),...

A bit new to this derivative stuff - would this be required for `default_rng_value` value too?

I think so. #2072 looks related (`casadi` not found), the only difference is that I did not try building up the `IDAKLUSolver`.

This is weird. I created a minimal example - https://github.com/Saransh-cpp/pybamm-idaklusolver-test/blob/main/.github/workflows/ci.yml - and it indeed does not work - https://github.com/Saransh-cpp/pybamm-idaklusolver-test/actions/runs/3115076483/jobs/5051607653 Maybe @martinjrobins can help?

The [workflow](https://github.com/Saransh-cpp/pybamm-idaklusolver-test/actions/runs/3115467411/jobs/5052389760) outputs - ``` Traceback (most recent call last): File "", line 1, in File "/opt/hostedtoolcache/Python/3.9.[14](https://github.com/Saransh-cpp/pybamm-idaklusolver-test/actions/runs/3115467411/jobs/5052389760#step:8:15)/x64/lib/python3.9/site-packages/pybamm/solvers/idaklu_solver.py", line 59, in __init__ raise ImportError(f"KLU is not installed: {idaklu_spec}") ImportError: KLU is...

A missing file? ``` Traceback (most recent call last): File "", line 1, in File "/opt/hostedtoolcache/Python/3.9.[14](https://github.com/Saransh-cpp/pybamm-idaklusolver-test/actions/runs/3115508691/jobs/5052473330#step:8:15)/x64/lib/python3.9/site-packages/pybamm/solvers/idaklu_solver.py", line 59, in __init__ raise ImportError(f"KLU is not installed: {idaklu_spec}") ImportError: KLU is not...

Adding the missing env variables worked! The passing workflow - https://github.com/Saransh-cpp/pybamm-idaklusolver-test/actions/runs/3137300340 `YAML` file - https://github.com/Saransh-cpp/pybamm-idaklusolver-test/blob/main/.github/workflows/ci.yml @Vaibhav-Chopra-GT, you can set the required variables in validation repository's workflows and then move all...

> P.S. there really needs to be a way to _just_ run docs previews if it's only a docs change - the Metalhead CI load is quite heavy Something like...

> https://github.com/FluxML/Metalhead.jl/runs/8228349979?check_suite_focus=true#step:6:39 is even weirder - Flux does seem to be in the environment, so how is it not defined? Maybe try `using Flux`? Also I think it would be...

There is a way to get the latest stable release, in fact, `dependabot` will do this for us 😉 - https://github.com/zarr-developers/zarr-python/blob/daad2fa86a32c3ed10871f6ba191ed3356b29e91/.github/dependabot.yml#L8-L11 We need to pin all the actions to a...