HeadsetControl icon indicating copy to clipboard operation
HeadsetControl copied to clipboard

Added json output of equalizer information of the device

Open nicola02nb opened this issue 1 year ago • 1 comments

Changes made

  • EqualizerInfo and EqualizerPreset and EqualizerPresets structs
  • Added EqualizerInfo and EqualizerPreset and EqualizerPresets structs to device struct
  • Added json output for EqualizerPreset and EqualizerPresets
  • Refactor of steelseries_arctis_nova_7.c for adding support of the new info to output

Checklist

  • [ ] I adjusted the README (if needed)
  • [x] For new features in HeadsetControl: I discussed it beforehand in Issues or Discussions and adhered to the wiki

nicola02nb avatar Jun 19 '24 10:06 nicola02nb

Just seen I've broken the --equalizer feature

nicola02nb avatar Jun 21 '24 11:06 nicola02nb

@Sapd I think that the check-whitespace fail is caused by the deprecated use of set-output in echo "::set-output name=checkout::"${log}"". The fix should be somethin like this: echo "checkout=${log}" >> $GITHUB_OUTPUT, if I'm not wrong

nicola02nb avatar Jul 04 '24 16:07 nicola02nb

Yep dont worry about the whitespace error. I will check the PR on the weekend

Sapd avatar Jul 04 '24 16:07 Sapd

Yeah, no problem, it was olny a suggetsion :)

nicola02nb avatar Jul 04 '24 16:07 nicola02nb

Thank you! sorry for the delay. I also added YAML output

Sapd avatar Jul 22 '24 14:07 Sapd

No worries, thanks for your work. If you want give a look to the GUI that I created on my gh

nicola02nb avatar Jul 23 '24 07:07 nicola02nb