Sanne Grinovero

> use_legacy_boolean_type regarding HANA, sorry it wasn't me introducing them. I believe all HANA related things are maintained by SAP's expert @breglerj . +1 to improve things in ORM 6...

> OK sorry @Sanne it was your name popped up in blame :-) Hey I try to refactor code sometimes, git will blame me often :) > Sure, I'm not...

It's an interesting point but I suspect there are good reasons for this; sadly I don't remember the details other than having seen such conversations in the past - we...

Note to self: If we decide to merge it (pending further testing on collections like @gsmet suggested) we're not going to backport it as the schema change would be annoying...

IMO conceptually we'd need a https://en.wikipedia.org/wiki/Bloom_filter Not keen to add a dependency though - could we check how close we get approximating it via an identity hashmap ?

Many thanks @pludov , this seems a rather important fix, but I'm rusty on ASM. I need to set aside some proper review time next week.

@NathanQingyangXu how did you create these classes? I assume via reverse engineering from the actual DB?

Ok then they are not BSD licensed, and you can choose to contribute them to the Hibernate project as LGPL (like you did in the headers), so it should be...

Was this abandoned?

> Instead, the sort of thing I often have is, say, 5 entities as inner classes of a test class, and sometimes I get table name collisions with inner classes...