SangamSwadiK

Results 39 comments of SangamSwadiK

@sn-ekstrand Did you try running it with sudo ?

> Thank you for this. It would be useful to have some tests for this addition so that we know it's doing what it's supposed to do. Would you be...

> I think at a minimum we'd want some unit tests to ensure that the ignored columns were really being ignored. I would maybe ignore the actual 'integration' tests (of...

@strickvl Hi, I have a noob question. I've written the tests, but I'm facing a type issue and getting a subclass error, its expecting the **ignored_columns** argument to be of...

@strickvl Hi, I've updated the tests and modified the ProfileStep. Please let me know if I can improve or if any changes is needed.

I've fixed the darglint errors for raising value errors and removed unused imports.

> @SangamSwadiK seems like you now used an email that hasnt signed the CLA yet. Would you mind doing it? Hi, I mistakenly used a different username and a email...

> Hi, sorry for the delay in getting back to you on this. I think you could try changing `ignored_columns:List[str]` and making it `ignored_columns: List[str] = None`. Not sure if...

> I haven't taken a look at the entire PR, but just quickly glanced over the comments and saw the discussion about an empty list as a default argument to...

> @SangamSwadiK As far as I can understand from code, we'll want an if condition that checks if the `ignore_columns` are emtpy/None anyway right? In that case I'd personally go...