gophertunnel icon indicating copy to clipboard operation
gophertunnel copied to clipboard

Customizable encryptors and compressors per protocol

Open JustTalDevelops opened this issue 3 years ago • 6 comments

In certain cases those settings can be undesired, although they should certainly be on by default.

JustTalDevelops avatar Jun 26 '22 20:06 JustTalDevelops

It might be better to have the compressors and encryptors configurable themselves, maybe in ListenConfigs or Protocol implementations. Could be useful for custom Protocol implementations.

JustTalDevelops avatar Jun 27 '22 03:06 JustTalDevelops

It might be better to have the compressors and encryptors configurable themselves, maybe in ListenConfigs or Protocol implementations. Could be useful for custom Protocol implementations.

I think this is the way to go. It doesn't make sense to put it in ListenConfigs, as compression/encryption is really only tweaked with when using Gophertunnel over a different Protocol.

JustTalDevelops avatar Jun 27 '22 18:06 JustTalDevelops

I wouldn't put this in Protocol either, these are both a different layer than the protocol. Without the correct compression type, you can't find the protocol.

Sandertv avatar Jun 27 '22 18:06 Sandertv

Where would you put this then? Listen/Dial configs?

JustTalDevelops avatar Jun 27 '22 19:06 JustTalDevelops

Probably, honestly.

Sandertv avatar Jun 27 '22 19:06 Sandertv

Coming back to this, with 1.19.30 coming, it would probably make sense to put this in the protocol, as we can now find the protocol before we need to (de)compress or encrypt.

Sandertv avatar Sep 05 '22 16:09 Sandertv