flecs icon indicating copy to clipboard operation
flecs copied to clipboard

Fix likes on touchbar (they were inverted)

Open andrew-mathieu opened this issue 2 years ago • 1 comments

When we tap on "👍", it doesn't leave a like but does the opposite

andrew-mathieu avatar Sep 09 '22 01:09 andrew-mathieu

When we tap on "👍", it doesn't leave a like but does the opposite

~~can't reproduce~~ nevermind, am stupid.

anytarseir67 avatar Sep 09 '22 23:09 anytarseir67

The issue still exists in v.19 - buttons still inverted.

l-laziz avatar Jan 03 '23 20:01 l-laziz

Looks like the change needed is on line 66 of the file (plugins/touchbar/back.js) instead:

-		controls = [previous, playPause, next, like, dislike];
+		controls = [previous, playPause, next, dislike, like];

I don't have time to make a PR to this repo at the moment sorry, but thought I'd highlight it in case anyone else wants to.

afairb avatar Jan 13 '23 15:01 afairb

Lol this PR only changed the import deconstruction order which is essentially only changing how the code looks 😂

I don't have time to make a PR to this repo at the moment sorry, but thought I'd highlight it in case anyone else wants to.

@Zo-Bro-23 wanna fix it?

Araxeus avatar Jan 13 '23 15:01 Araxeus

Done (#968)!

Zo-Bro-23 avatar Jan 14 '23 00:01 Zo-Bro-23