flecs icon indicating copy to clipboard operation
flecs copied to clipboard

[Bug]: Lyrics aren't centered after the last update

Open shyney69 opened this issue 9 months ago • 8 comments

Preflight Checklist

  • [x] I use the latest version of YouTube Music (Application).
  • [x] I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • [x] I understand that th-ch/youtube-music has NO affiliation with Google or YouTube

YouTube Music (Application) Version

3.8.0.0

Checklists

What operating system are you using?

Windows

Operating System Version

Windows 11

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

3.7.0.0

Reproduction steps

The lyrics in the app used to be symmetrical and cenetred, now they are aligned to the left, just open the app.

Image

Expected Behavior

It should be aligned to the center, probably a quick fix.

Actual Behavior

The lyrics are aligned to the left.

Enabled plugins

Lyrics Plugin

Additional Information

No response

shyney69 avatar Mar 26 '25 15:03 shyney69

bro has the timestamps on :skull: thanks for the report, I'll try to fix this

ArjixWasTaken avatar Mar 26 '25 15:03 ArjixWasTaken

bro has the timestamps on 💀 thanks for the report, I'll try to fix this

IMO, them not being centered looks nicer. Would it be possible to make it a config option? I've tried doing it with custom css before with no luck for some reason

Lythium4848 avatar Mar 26 '25 18:03 Lythium4848

bro has the timestamps on 💀 thanks for the report, I'll try to fix this

bro has bro. They were on by default bro. Bro has bro skull emoji bro.

shyney69 avatar Mar 27 '25 09:03 shyney69

bro has the timestamps on 💀 thanks for the report, I'll try to fix this

IMO, them not being centered looks nicer. Would it be possible to make it a config option? I've tried doing it with custom css before with no luck for some reason

it's okay if it's added as an option for people who like left alignment, but symmetrical looked nice to me :(

shyney69 avatar Mar 27 '25 09:03 shyney69

bro has the timestamps on 💀 thanks for the report, I'll try to fix this

bro has bro. They were on by default bro. Bro has bro skull emoji bro.

I am an author of that plugin, and I can assure you that they are not on by default. https://github.com/th-ch/youtube-music/blob/master/src/plugins/synced-lyrics/index.ts#L20

ArjixWasTaken avatar Mar 27 '25 09:03 ArjixWasTaken

bro has the timestamps on 💀 thanks for the report, I'll try to fix this

bro has bro. They were on by default bro. Bro has bro skull emoji bro.

I am an author of that plugin, and I can assure you that they are not on by default. https://github.com/th-ch/youtube-music/blob/master/src/plugins/synced-lyrics/index.ts#L20

and I am the end user who never clicked any settings in the plugin settings because I might break things and just use them as they are. bro is unaware of bros own plugin

shyney69 avatar Mar 27 '25 12:03 shyney69

In all commits that have touched that file, the default has always been false.

  • https://github.com/th-ch/youtube-music/blob/9b3cbe8e013d4f81080a8a97462dac0fe646d7ff/src/plugins/synced-lyrics/index.ts#L20
  • https://github.com/th-ch/youtube-music/blob/8750b54f766c735ff039c6be454427f17d4737e2/src/plugins/synced-lyrics/index.ts#L20
  • https://github.com/th-ch/youtube-music/blob/533b96d1f6f2254027b4a0e7ba9187f2e34e3ced/src/plugins/synced-lyrics/index.ts#L20
  • https://github.com/th-ch/youtube-music/blob/51da259c978b1dd2f50829105f9c97bbcd3493ab/src/plugins/synced-lyrics/index.ts#L20
  • https://github.com/th-ch/youtube-music/blob/4b35a967782e2e435d7942d814825545d104d33e/src/plugins/synced-lyrics/index.ts#L20

And now that I think about it, I don't remember making the lyrics be centered....

PS: Since you chose to insult me, I won't be spending any more time on this ticket, I am not obligated to since I am not a maintainer but a contributor.

ArjixWasTaken avatar Mar 27 '25 12:03 ArjixWasTaken

@shyney69 The centered lyrics are not intended behavior of this plugin. It was possible to make previously if you had Lyrics Genius plugin enabled. With it disabled, timestamps are also aligned to the left. And also, please, don't insult the contributors and maintainers, they're doing their work for free for your convenience.

Dzheremi2 avatar Mar 27 '25 17:03 Dzheremi2