SanderMertens
feat(plugin): settings-ui
About
This is a plugin that introduces a new settings interface! Configuring everything through menu options is not only a pain, but it is also a pain! (double pain!) I propose that this plugin is enabled by default, but I won't insist on that if you think otherwise.
TODO
- [x] Add settings button
- [x] Add settings modal
-
- [x] General
-
- [ ] Appearance
-
- [x] Plugins
-
- [ ] Advanced
-
- [x] About
Screenshots
| Full sidebar | Mini sidebar |
|---|---|
~~Before I develop this further, I'd like your opinions, any suggestions as to what/how the settings should look like?~~
~~@th-ch, @JellyBrick, @Su-Yong~~
Edit: 2 weeks have passed w/o any message, so I'll continue with whatever I think looks best.
Question:
Should the settings: a) be applied as soon as you change them (like the menu) b) be applied after pressing a confirm button to close the modal
@JellyBrick, @th-ch
https://github.com/th-ch/youtube-music/pull/3066#issuecomment-2781732433 a) Imo as that's the expected behaviour most users would think of. Also so the users won't be confused as to why their selected settings don't work immediately. It would be better if a pop up to restart the client is shown with settings that needs a restart to take effect. PS ignore my suggestion if I (a user) am not qualified or supposed to suggest or share anything here. I just wanted to give my two cents on what I think would be best for the users overall.
@Rairof you didn't understand what I meant, so of course you'd think so
I meant we'd not allow the user to close their settings unless there are no unsaved changes, just like how discord does it
https://github.com/th-ch/youtube-music/pull/3066#issuecomment-2837458315 In that case. my proposal was to automatically apply said user changes inside the settings menu (like how it is now with the in-app menu) with the sole exception being the few plugins/functions that require a restart to function.
Question:
Should the settings: a) be applied as soon as you change them (like the menu) b) be applied after pressing a confirm button to close the modal
@JellyBrick, @th-ch
a + throttle (e.g. 5sec)
