flecs icon indicating copy to clipboard operation
flecs copied to clipboard

[Bug]: Ads not being blocked while using the " In-Player " adblocker

Open XCalibur5678 opened this issue 1 year ago • 18 comments

Preflight Checklist

  • [X] I use the latest version of YouTube Music (Application).
  • [X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • [X] I understand that th-ch/youtube-music has NO affiliation with Google or YouTube

YouTube Music (Application) Version

3.3.2

Checklists

  • [ ] I use the portable version of the YouTube Music Application.
  • [ ] I can reproduce this issue in the official YTM web version.

What operating system are you using?

Windows

Operating System Version

Windows 11 23H2 22631.3155

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

  1. Switch to Plugins>Adblocker>Blocker>In Player
  2. Play any song

Expected Behavior

Music to play without any ads

Actual Behavior

2 30 seconds ads playing

Enabled plugins

  1. Adblocker
  2. Album Actions
  3. Blur Navigation Bar
  4. Downloader
  5. In app Menu
  6. Lyrics Genius
  7. Navigation
  8. SponsorBlock
  9. Taskbar media control
  10. Video Toggle

Additional Information

If using the In player ad blocker , ads aren't being blocked . Using the " blocklists " function mitigates this issue . Hereby attaching a screenshot of the ad playing . Please feel free to reach out to me if you need any more information,

image

XCalibur5678 avatar Mar 02 '24 13:03 XCalibur5678

I can confirm this is happening on Linux as well:

Linux Version: Ditro: Fedora 39 Architeture: x86_64

Version: 3.3.2

Enabled Plugins:

  1. Adblocker (In-Player)
  2. Discord Rich Presence
  3. Navigation

Please let me know if I can be of further assistance. I love using this tool :D

image

Joey451-OG avatar Mar 19 '24 20:03 Joey451-OG

Also have this issue. Swapping between in-player and blocklist does nothing and ads still appear.

OS: Windows 10 Home OS Version: 10.0.19045 Build 19045 System Type: x64-based PC

YT Music Version: 3.3.4

Plugins Enabled: Ad Blocker Album Color Theme Discord Rich Presence Downloader In-App Menu Navigation Sponsorblock

BrandTruong avatar Mar 26 '24 06:03 BrandTruong

did this issue fixed? using 3.3.5 still appeared.

frrrrrits avatar Mar 27 '24 04:03 frrrrrits

did this issue fixed? using 3.3.5 still appeared.

YT has changed the logic around showing ads, please use blocklists mode until we can figure out the issue.

JellyBrick avatar Mar 27 '24 17:03 JellyBrick

I'm going to copy my solution here:

Toggle with blocklists under Blocker in the ad blocker Plugin. Go to Options---> Advanced options---> Edit config.json and change:


			"additionalBlockLists": [],

to

			"additionalBlockLists": [
				"https://filters.adtidy.org/extension/ublock/filters/122_optimized.txt"
			],

and restart the app That solves the ads issue for me

Adherence to protocol is fine, but don't use it to needlessly burying the issue and solutions to it

Trixarian avatar Apr 11 '24 11:04 Trixarian

https://github.com/th-ch/youtube-music/issues/1955#issuecomment-2047699372 is also a viable fix. Using a link instead of a path removes the need to download the list

Trixarian avatar Apr 11 '24 11:04 Trixarian

If I'm not mistaken, it looks like Ublock Origin uses this service (adtidy.org).

We should add it to the default block list here.

Joey451-OG avatar Apr 11 '24 15:04 Joey451-OG

If I'm not mistaken, it looks like Ublock Origin uses this service (adtidy.org).

We should add it to the default block list here.

It's an optimized list maintained by AdGuard. It's generally lighter on resources and more up to date than the list featured in the adblockers themselves - since the one I'm using (Fanboy Annoyances) /is/ on that lists, just out of date. Why I prefer them over uBlock Origin's in general

Trixarian avatar Apr 11 '24 15:04 Trixarian

+1, blocklist is working fine.

lucastwg avatar Apr 11 '24 21:04 lucastwg

Update

  • Blocklist mode is fixed by #1966
  • In-Player mode is not fixed yet.

JellyBrick avatar Apr 13 '24 07:04 JellyBrick

I'm going to copy my solution here:

Toggle with blocklists under Blocker in the ad blocker Plugin. Go to Options---> Advanced options---> Edit config.json and change:

			"additionalBlockLists": [],

to

			"additionalBlockLists": [
				"https://filters.adtidy.org/extension/ublock/filters/122_optimized.txt"
			],

and restart the app That solves the ads issue for me

Adherence to protocol is fine, but don't use it to needlessly burying the issue and solutions to it

where to put this line in the json? i'm trying everything. Ads still there

peppepascale avatar May 01 '24 17:05 peppepascale

i think i found how to activate this, had to switch to "block list" in the app: plugins/ad-blocker/block/ then block list then the line appears in the json and i was able to fill it like explained above. lets see if works now

peppepascale avatar May 01 '24 18:05 peppepascale

This is not anything bad, but correct me if i'm wrong, back in 2023 didn't we decide to switch to "In Player" because of the RAM usage leak that was happening from the "Blocklists" option?

Did we ever fix that? I got busy with university so I had to temporarily drop this project

DereC4 avatar May 05 '24 09:05 DereC4

@DereC4 Yes, that issue has been resolved.

JellyBrick avatar May 11 '24 01:05 JellyBrick

If this is the definitive fix to the issue of ads not being blocked then shouldn't this be pushed in the next update?

VeryHolyCheeeese avatar May 14 '24 10:05 VeryHolyCheeeese

#1955 (comment) is also a viable fix. Using a link instead of a path removes the need to download the list

Note that this solution breaks search feature.

farsdewibs0n avatar May 14 '24 19:05 farsdewibs0n

This is happening on Mac as well:

Macbook air m2 Sonoma 14.4.1 Architeture: arm64

Enabled plugins:

  • All the default ones(didn't change anything)

Version: 3.3.6

xndrpr avatar May 17 '24 17:05 xndrpr

@DereC4 Yes, that issue has been resolved.

neat

DereC4 avatar May 17 '24 22:05 DereC4

Fixed at 1f1efac4660fb7d0867cd67d9b9f6776331f4638

JellyBrick avatar Jun 01 '24 00:06 JellyBrick

neat

DereC4 avatar Jun 04 '24 03:06 DereC4