Sanchith Hegde
Sanchith Hegde
> I'm sorry for the delay! I have become busy with work and juggling a few other issues. @IsaacCloos No problem, we understand that contributors have a personal life, and...
> [...] Honestly I'm not sure it was a good idea for me to offer help because I've never contributed to an open source before (so I'd need help with...
> I assume this thread is being taken care of by @IsaacCloos and that's way you suggested #899?! I suggested #899 since we're not yet sure if @IsaacCloos would take...
@EliKalter I'll be assigning this to you, as discussed over Discord.
@EliKalter Please let us know if you're still working on this issue or still interested in working on it. There hasn't been any recent activity on this thread, or any...
I'll be opening this issue for other contributors to pick up.
Sure @lokesh185, I'll assign this to you. You can reach out to us in case of any queries either on this thread, or on our Discord server.
> > and to ensure that invalid card numbers are caught during deserialization? > > Also I wasn't sure what you meant by this. Could you add tests to ensure...
> Just to be clear, should I try to implement `Deserialize` manually for `CardNumber` according to the example that you provided? Yes, the `Deserialize` implementation could just use the `FromStr`...
> Does this mean I leave them in for now and you take care of this? You can either leave it in and one of us will take care of...