Sam Gunaratne
Sam Gunaratne
### About When creating a ServiceBinding resource with a `.spec.service` reference that cannot be resolved, the ServiceBinding resource does not set a failure condition and the controller does not include...
The service-binding controller uses [this unsafe method](https://github.com/vmware-labs/service-bindings/blob/1786b9da9656e2c550fdbef0ca0fb7e77e2b2522/pkg/resolver/serviceable_resolver.go#L54) to determine the GVR from the GVK to setup a watch dynamically. [This method](https://github.com/kubernetes/apimachinery/blob/master/pkg/api/meta/restmapper.go#L126) attempts to guess the GVR with some string checks...
Hey Scott, Something we have done a bunch of times using regular controller-runtime tooling is to setup watches for resources that arn't known about upfront. For example, we might have...
Going through the dev setup I found I had to set `DB_CONNECTION_STRING` for my docker composed mysql. * [x] I have reviewed the [contributing guide](https://github.com/cloudfoundry/cloud_controller_ng/blob/main/CONTRIBUTING.md) * [x] I have viewed,...
* [x] I have viewed signed and have submitted the Contributor License Agreement
TODO: work in progress Thought: We could split this PR and just add the logic to conditionally add the nc call and then operators could specifically set `-1` on the...
## Issue [Request_timeout_in_seconds](https://github.com/cloudfoundry/capi-release/blob/develop/jobs/cloud_controller_ng/spec#L288C3-L288C29) is configurable on the capi-release and sets the [Thin Runner request timeout](https://github.com/cloudfoundry/cloud_controller_ng/blob/656dc81a4726f155f664c7d3541daf05c32f5e84/lib/cloud_controller/runners/thin_runner.rb#L18). This does not appear to be set for [Puma Runner](https://github.com/cloudfoundry/cloud_controller_ng/blob/656dc81a4726f155f664c7d3541daf05c32f5e84/lib/cloud_controller/runners/puma_runner.rb#L4) ## Possible Fix Sadly, It...
* X-CF-PROCESS-INSTANCE: * X-CF-PROCESS-INSTANCE:: **note** This should not be merged until the work has been complete in GoRouter and released in cfd. ### Are you submitting this PR against the...
### What is this change about? Adds test for Canary steps. ### Please provide contextual information. * CAPI change: https://github.com/cloudfoundry/cloud_controller_ng/pull/4219 * CF CLI change: https://github.com/cloudfoundry/cli/pull/3390 ### What version of cf-deployment...
For both service plans and service offerings. Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with: * A short explanation...