toipe icon indicating copy to clipboard operation
toipe copied to clipboard

Add support for custom books

Open wisarmy opened this issue 2 years ago • 4 comments

Specify a book file (such as TXT) , by paragraph typing test

wisarmy avatar Nov 24 '23 03:11 wisarmy

I want to add this feature, can you give me a code design idea?

wisarmy avatar Nov 24 '23 08:11 wisarmy

I would look at how word lists are used currently. Conceptually, a custom book is sort of like a word list with randomization in terms of which group of words you're typing (a random starting point in the book) as opposed to randomly picking words to form the group. But the test shouldn't care where it got its words from, so maybe design an interface to wrap book + wordlist functionality

benliepert avatar Nov 28 '23 16:11 benliepert

https://github.com/Samyak2/toipe/compare/main...wisarmy:toipe:feature-book The issue purpose is to test meaningful sentences in books, not random words. I submitted an immature implementation, still missing the status of the position in the book

wisarmy avatar Nov 29 '23 04:11 wisarmy

Nice! looks good. I have a couple suggestions when you create a PR

benliepert avatar Nov 30 '23 13:11 benliepert