LightHook icon indicating copy to clipboard operation
LightHook copied to clipboard

Will not work on functions with jmp/cmp/nearcall/ any relative offset in the first 14 bytes

Open po0p opened this issue 1 year ago • 1 comments

Hey, while overall a great and simple library, it seem to break if a target function has a nearcall (E8 ? ? ? ?) in the first 14 bytes. Possibly also will break on jmp and cmp if relative displacement is used. Reason being this: https://github.com/SamuelTulach/LightHook/blob/fcdba7570fa564ae23c2a66cdf71b9d9334d579c/Source/LightHook.h#L186 But, considering not having to bring a fullass disassembler to use LH, not an issue per se, just letting you know ;) Thanks for a great project!

po0p avatar Aug 29 '24 10:08 po0p

Yeah it's not really fixable. I have modified the README to state that more clearly.

SamuelTulach avatar Sep 28 '24 13:09 SamuelTulach