SamuelDeleglise
SamuelDeleglise
OK, it looks like I was to quick in saying the bug was solved (I am talking about the initial one): Actually on python 3.6 and 3.7 my fix is...
OK, the final fix is here: https://github.com/lneuhaus/pyrpl/commit/a37d468c1976a7727bcdb9fc9a80485aaffe9f48 That was not many lines of code but testing on 2.7, 3.5, 3.6 and 3.7 on notebooks + unittests was quite lengthy...
It passes unittests on all these versions and a quick test of the scope gui is also fine in the notebooks...
OK, I have already advanced quite a bit on the python3-only branch. The code will be compatible with python 3.5, 3.6 and 3.7. Support for python
I also suggests that `running_state` should be a "read-only property" since it is misleading to load the state of an instrument that is running for instance... To launch an instrument,...
I have worked quite a bit on the unittests for the branch python 3 only: now all the 3 acquisition_modules (Scope, SpectrumAnalyzer and NetworkAnalyzer) fulfill the unittests on python 3.5,...
Yes, I went through various possibilities until I went back to this one... Maybe a slightly cleaner option would be to take the private attribute `_running_state` out of the setup_attributes...
- OK I implemented the `run_continuous` boolean attribute as part of the _setup_attributes... I believe it makes more sense. - By the way, I have measured something like 20 fps...
I basically need to add some comments and help-strings. I will try to do that tonight and issue a pull request. But also, I am proposing below a few modification...
Two more things: - I realized while debugging the python-3-only version that there was actually still a flaw in my bugfix for develop0.9.3. The function `_wait_for_done()` for python 3.7 was...