ONE icon indicating copy to clipboard operation
ONE copied to clipboard

[ONE-Dockerizing] Q) about onecc-docker -h option

Open morumoru opened this issue 2 years ago • 6 comments

I am wondering about handling -h option to onecc- docker. There are onecc-docker's -h option and onecc's -h option and onecc's subtool's -h option. I thought about making a new flag for onecc's -h option (e.g -a) but in this case, subtool's -h option must be handled too. How can I handle this situaltion?

#related draft PR #9800

morumoru avatar Sep 27 '22 02:09 morumoru

@morumoru , you don't need to add WHAT and WHY

Just add question body, and I don't think you need the Question header. And instead of Add argparse to onecc-docker, Q) about onecc-docker -h option would be better for the title to express this question issue.

seanshpark avatar Sep 27 '22 02:09 seanshpark

How about introduce a double dash("--")? It could indicate the end of onecc-docker's option. You can refer to https://github.com/Samsung/ONE/blob/5573f5b11a6d63a803c6d9892292fbed72a23b11/compiler/one-cmds/one-infer.

https://github.com/Samsung/ONE/blob/5573f5b11a6d63a803c6d9892292fbed72a23b11/compiler/one-cmds/one-infer#L114

mhs4670go avatar Sep 27 '22 04:09 mhs4670go

Oh! then we can get onecc's help message by calling ./onecc-docker -- -h! Thank you for your advice!

morumoru avatar Sep 27 '22 05:09 morumoru

Then onecc-docker -h always outputs the onecc-docker's help message?

jyoungyun avatar Sep 28 '22 03:09 jyoungyun

Then onecc-docker -h always outputs the onecc-docker's help message?

Yes. Is there any other case?

mhs4670go avatar Sep 28 '22 04:09 mhs4670go

First, we decided not to consider help message in various cases. Now, only onecc-docker help messages will be displayed. We will think about the next step later.

jyoungyun avatar Sep 28 '22 12:09 jyoungyun

I will make a new issue when I proceed with this issue. I will close it.

jyoungyun avatar Nov 30 '22 05:11 jyoungyun