ONE icon indicating copy to clipboard operation
ONE copied to clipboard

[mir] Do we still need mir-related components?

Open binarman opened this issue 2 years ago • 3 comments

What?

I propose to delete https://github.com/Samsung/ONE/tree/master/compiler/mir and related components from source code.

Why?

This is an old part of the project, and I am not sure if someone still need this. It breaks time to time and requires maintenance.

+cc @seanshpark

binarman avatar Jul 19 '22 14:07 binarman

Source itself is in the history and existing release archive files. It's OK for me to deprecate mir.

CC @lemmaa

seanshpark avatar Jul 19 '22 21:07 seanshpark

... It breaks time to time and requires maintenance.

@binarman , Is that a big burden? Does this module have no build dependencies from other modules we need? How about just excluding it from the default build target without deleting the source code? Of course, it will require a lot of modifications to use it again in the future.

lemmaa avatar Jul 25 '22 13:07 lemmaa

How about just excluding it from the default build target

We can revise CMake to skip the module if CMakeLists.txt is absent (by renameing it)

seanshpark avatar Jul 25 '22 21:07 seanshpark