ONE icon indicating copy to clipboard operation
ONE copied to clipboard

[one-import-onnx] help message

Open seanshpark opened this issue 2 years ago • 4 comments

Help of one-import-onnx shows

$ one-import-onnx usage: one-import-onnx [-h] [-v] [-V] [-C CONFIG] [-i INPUT_PATH] [-o OUTPUT_PATH] [-I INPUT_ARRAYS] [-O OUTPUT_ARRAYS] [--model_format MODEL_FORMAT] [--converter_version CONVERTER_VERSION] [--unroll_rnn] [--unroll_lstm] [--save_intermediate] one-import-onnx: error: the following arguments are required: -i/--input_path -o/--output_pat

which has [-I INPUT_ARRAYS] [-O OUTPUT_ARRAYS] but not necessary. this came from tf2tfliteV2.py tool and is for options of v1, if I am not wrong.

Let's fix this not to be shown in the help message.

seanshpark avatar May 23 '22 10:05 seanshpark

CC @mhs4670go

seanshpark avatar May 23 '22 10:05 seanshpark

related: https://github.com/Samsung/ONE-vscode/issues/693

seanshpark avatar May 23 '22 10:05 seanshpark

Question.

one-import-onnx also has --model_format and --converter_version. Is there any case where user should call --model_format graph_def or --converter_version v1?

https://github.com/Samsung/ONE/blob/c426200a29e4236c73562331c70e5bf35663c0a8/compiler/one-cmds/one-import-onnx#L75-L78

hyunsik-yoon avatar Jul 04 '22 03:07 hyunsik-yoon

tf2tfliteV2_group.add_argument('--model_format', default='saved_model') tf2tfliteV2_group.add_argument('--converter_version', default='v2')

These two lines are given as tf2tfliteV2 requires them but not necessary to ask users.

Is there any case where user should call --model_format graph_def or --converter_version v1?

I think not.

seanshpark avatar Jul 04 '22 04:07 seanshpark