ONE-vscode icon indicating copy to clipboard operation
ONE-vscode copied to clipboard

[OneExplorer] Review the necessity of NodeMap

Open dayo09 opened this issue 1 year ago • 1 comments

What?

NodeMap store path to node relationship. To fulfill this functionality, node insertion/deletion should be related to all the file creation/deletion.

Initially it was introduced to keep node status in spite of hide/show status. Let's check if it's really needed. Maybe nodes can be conditionally mapped to TreeItem, so that node map can be deprecated.


DRAFT: #1717

dayo09 avatar Oct 19 '23 06:10 dayo09

Usages

It maps filesystem change to node

  • onDidDelete, onDidCreate, onDidChange
    • events take file uri. NodeMap helps getting the corresponding node instantly.
  • revealInOneExplorer
    • it also takes file uri. ditto.

dayo09 avatar Oct 19 '23 06:10 dayo09