ONE-vscode
ONE-vscode copied to clipboard
[third_party] Add catapult as git submodule
This commit adds catapult as submodule to use trace2html.
ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]
Add catapult as a submodule
Why?
I tried to import only the related catapult directories. It exceeded 3000+ lines changes, as can be seen in this PR
For extensibility, it could be better to import the project as a submodule.
Originally posted by @dayo09 in https://github.com/Samsung/ONE-vscode/issues/1611#issuecomment-1668839894
git submodule update --init --recursive
./third_party/catapult/tracing/bin/trace2html res/samples/traces/sample.timeline.json
@dayo09 , have you checked the license for the cataplut project? If you want to introduce an external module, it is better to create a separate issue for it, check and organize all matters including the license, and proceed with PR only after taking appropriate measures.
When I checked the license of catapult
module, this project is BSD-3-Clause license even though the LICENSE file in the catapult-project is Chromium
. SOSHub said that we can use this project under the license compliance.
https://opensource.sec.samsung.net/view/search?searchword=Y2F0YXB1bHQ
/cc @lemmaa
@jyoungyun , my other concern is when deploying. Actually, this tool should be distributed and used. What kind of package structure will it have then?
@lemmaa @jyoungyun I have created the issue to talk about it. :-D