ONE-vscode
ONE-vscode copied to clipboard
[MPQEditor] Introduce VISQ data
This draft introduces usage VISQ data for the task of manual mixed precision quantization.
Basic editing:
https://user-images.githubusercontent.com/112689352/235146024-3c052bdf-b936-4246-8427-2ef12ee9d84f.mp4
Show/Hide:
https://user-images.githubusercontent.com/112689352/235146151-b3af945e-e9e0-47e2-b3d6-e71fb28d06a3.mp4
CancelScrollToSelection:
https://user-images.githubusercontent.com/112689352/235146293-2ea242a5-b5c4-4093-87f1-f77d5a639e7e.mp4
See attachment for sample circle model and computed visqs: circle_model_and_visqs.zip
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]
When I try to select a node, I need to click the operator name. By clicking the other parts of the operator node box, I cannot select the node. Do you intend it? Could you enable selection on any part of operation boxes?
When I try to select a node, I need to click the operator name. By clicking the other parts of the operator node box, I cannot select the node. Do you intend it? Could you enable selection on any part of operation boxes?
@dayo09 Thank you. I'll try.
@dayo09
It's fixed. Also there were issues with losing selection after changing nodes style by changing render mode of graph:
e.g. clicking 'Show Attributes' shows all specific nodes as deselected.
They are fixed also.
@seanshpark
In Part-editor
clicking middle of the box doesn't selects operator and choosing other regime deselects previous selection.
Is it intended?
https://github.com/Samsung/ONE-vscode/assets/112689352/5b023178-2278-439c-b047-87a57d31e06e
If it's not intended, then this draft fixes it, otherwise i'll have to introduce new mode, m.b. mpqselector
.
@seanshpark
please take another look at https://github.com/Samsung/ONE-vscode/pull/1543#issuecomment-1552804838
do i need to split code paths for PartEditor
and MPQEditor
?
In Part-editor clicking middle of the box doesn't selects operator and choosing other regime deselects previous selection. Is it intended?
No, maybe UI bug.
do i need to split code paths for PartEditor and MPQEditor ?
I don't understand what you mean by "split"
I don't understand what you mean by "split"
I mean to introduce another viewing mode in circlegraph/view.js
like it was done for visqselector
. But if it's a bug, i'll provide PR that fixes it.
But if it's a bug, i'll provide PR that fixes it.
Please do not try to fix this bug.
@seanshpark Actually this draft fixes it.
Actually this draft fixes it.
Anyway I do not want to accept changes as of now.