ONE-vscode icon indicating copy to clipboard operation
ONE-vscode copied to clipboard

[MPQEditor] Introduce VISQ data

Open stamalakhov opened this issue 1 year ago • 10 comments

This draft introduces usage VISQ data for the task of manual mixed precision quantization.

Basic editing:

https://user-images.githubusercontent.com/112689352/235146024-3c052bdf-b936-4246-8427-2ef12ee9d84f.mp4

Show/Hide:

https://user-images.githubusercontent.com/112689352/235146151-b3af945e-e9e0-47e2-b3d6-e71fb28d06a3.mp4

CancelScrollToSelection:

https://user-images.githubusercontent.com/112689352/235146293-2ea242a5-b5c4-4093-87f1-f77d5a639e7e.mp4

See attachment for sample circle model and computed visqs: circle_model_and_visqs.zip

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]

stamalakhov avatar Apr 28 '23 12:04 stamalakhov

When I try to select a node, I need to click the operator name. By clicking the other parts of the operator node box, I cannot select the node. Do you intend it? Could you enable selection on any part of operation boxes?

dayo09 avatar May 12 '23 00:05 dayo09

When I try to select a node, I need to click the operator name. By clicking the other parts of the operator node box, I cannot select the node. Do you intend it? Could you enable selection on any part of operation boxes?

@dayo09 Thank you. I'll try.

stamalakhov avatar May 12 '23 05:05 stamalakhov

@dayo09 It's fixed. Also there were issues with losing selection after changing nodes style by changing render mode of graph: image e.g. clicking 'Show Attributes' shows all specific nodes as deselected. They are fixed also.

stamalakhov avatar May 12 '23 09:05 stamalakhov

@seanshpark In Part-editor clicking middle of the box doesn't selects operator and choosing other regime deselects previous selection. Is it intended?

https://github.com/Samsung/ONE-vscode/assets/112689352/5b023178-2278-439c-b047-87a57d31e06e

If it's not intended, then this draft fixes it, otherwise i'll have to introduce new mode, m.b. mpqselector.

stamalakhov avatar May 18 '23 09:05 stamalakhov

@seanshpark please take another look at https://github.com/Samsung/ONE-vscode/pull/1543#issuecomment-1552804838 do i need to split code paths for PartEditor and MPQEditor ?

stamalakhov avatar May 24 '23 07:05 stamalakhov

In Part-editor clicking middle of the box doesn't selects operator and choosing other regime deselects previous selection. Is it intended?

No, maybe UI bug.

do i need to split code paths for PartEditor and MPQEditor ?

I don't understand what you mean by "split"

seanshpark avatar May 24 '23 08:05 seanshpark

I don't understand what you mean by "split"

I mean to introduce another viewing mode in circlegraph/view.js like it was done for visqselector. But if it's a bug, i'll provide PR that fixes it.

stamalakhov avatar May 24 '23 08:05 stamalakhov

But if it's a bug, i'll provide PR that fixes it.

Please do not try to fix this bug.

seanshpark avatar May 24 '23 08:05 seanshpark

@seanshpark Actually this draft fixes it.

stamalakhov avatar May 24 '23 08:05 stamalakhov

Actually this draft fixes it.

Anyway I do not want to accept changes as of now.

seanshpark avatar May 24 '23 08:05 seanshpark