ONE-vscode icon indicating copy to clipboard operation
ONE-vscode copied to clipboard

[CircleEditor] Refactoring structure and codes

Open llFreetimell opened this issue 3 years ago • 1 comments

What?

Let's refactor overall structure and source codes for CircleEditor.

Why?

  • To improve performance
  • To improve static analysis score
  • To improve readability and maintainability
    • Remove source codes which are not related with editing circle file
    • Rename variable and functions
  • To fix bugs

Draft

  • #1454

TODO Items

  • [ ] Minimize duplicated source codes
    • [ ] Reposition external source codes
    • [ ] Remove not modified source codes from our own codes
  • [ ] Remove source codes which are not related with editing circle file
  • [ ] Rename variable and functions which have unclear names
  • [ ] Improve performance
    • [ ] Substitute opening a file with rendering graph after editing
    • [ ] Do not change when before and after are same
  • [ ] Clean codes
    • [ ] Separate value validation function when save
  • [ ] Fix bugs
    • [ ] Edit custom attribute --> Ctrl+z --> arrows are dismissed
    • [ ] BCQ(maybe some other operations too) attribute types are null
    • [ ] Custom options only supports few types
    • [ ] Even invalid attribute values are given, changes are generated

llFreetimell avatar Nov 09 '22 06:11 llFreetimell