ONE-vscode icon indicating copy to clipboard operation
ONE-vscode copied to clipboard

[OneExplorer] Support viewer for tflite/onnx

Open dayo09 opened this issue 2 years ago • 3 comments

What?

Let's support viewer for tflite/onnx. Logically, netron support boths, but it seems that the current circle-dedicated viewer (CircleViewer) is not working with tflite/onnx files.

The error message showed up when I tried to open a tflite file with circle viewer. image

/cc @lemmaa @seanshpark

dayo09 avatar Aug 25 '22 08:08 dayo09

@seanshpark AFAIK, the circle-netron supports tflite/onnx files. However, it seems that our CircleViewer doesn't support them. Do you think that it's possible to support tflite/onnx files, too?

dayo09 avatar Aug 25 '22 08:08 dayo09

Do you think that it's possible to support tflite/onnx files, too?

Current implementation: NO

How netron supports multiple formats?

  • it dynamically loads file loader .js files

How current circle viewer control works?

  • static loading of circle file loader codes and some fixed codes based on handing circle files
  • has some modification for partition editing that may disturb loading tflite/onnx

So, IMHO, how to support tflite/onnx files?

  • for simplicity, add another module for tflite and onnx both or two modules for each

seanshpark avatar Aug 29 '22 00:08 seanshpark

for simplicity, add another module for tflite and onnx both or two modules for each

Oh, therefore we need to port other modules to support tflite/onnx viewers... :-D

/cc @Samsung/one-vscode

dayo09 avatar Aug 29 '22 06:08 dayo09