ONE-vscode icon indicating copy to clipboard operation
ONE-vscode copied to clipboard

[CI] Replace csslint with maintained CSS linter

Open ai-moiseev opened this issue 2 years ago • 0 comments

What?

Currently there's csslint utility to check style and formatting of CSS files. It seems this utility is no longer actively developed anymore and it doesn't support many modern standard CSS features (for example, CSS grid layout).

Why?

PR #1109 fails on CI because csslint utility doesn't properly support CSS grid options.

Proposed solutions

https://github.com/Samsung/ONE-vscode/pull/1109#issuecomment-1197582715:

Sounds good to me.

  • https://npmtrends.com/css-lint-vs-csscomb-vs-csslint-vs-stylelint

How about discuss this in a separate issue? Thanks. :-)

stylelint seems as most complete, popular and actively developed solution. However, its default config produces a big amount of errors on the existing codebase. I've prepared config which relaxes some of its checks so CI will be able to pass. Later we may introduce more strict style checks and re-format existing stylesheets.

PR which contains stylelint config: #1114

ai-moiseev avatar Jul 28 '22 14:07 ai-moiseev