GearVRf icon indicating copy to clipboard operation
GearVRf copied to clipboard

Stickers

Open apjagdale opened this issue 6 years ago • 11 comments

Added screenshot capture feature by using 3 Pixel Buffer objects. New class introduced : GVRSticker(GVRContext gvrContext, String tag, long interval)

  • tag for outputting PNG's to the SD Card along with appended frame ID in folder GearVRFScreenshots
  • (interval) Time in milliseconds to take screenshot at that interval

Methods:

  • start/stopCapturing()

GearVRf DCO signed off by: Abhijit Jagdale [email protected]

apjagdale avatar Aug 03 '18 22:08 apjagdale

We are using horizontal/ vertical flip shaders, or post effects just for inverting a scene. we should be modifying mvp instead to rotate or flip the scene instead of all that overhead which is not efficient. Which will also avoid creating unnecessary render targets.

roshanch avatar Aug 06 '18 19:08 roshanch

Couple of tests I believe would be useful. There is a backend adapter that no longer compiles.

liaxim avatar Aug 07 '18 15:08 liaxim

Have you verified screenshotting with all backend adapters?

liaxim avatar Aug 07 '18 16:08 liaxim

What about generating stickers in "headless mode"? Where the framework is only used to render into the images as a background "service"? Should there be all new backend adapter for that mode?

liaxim avatar Aug 07 '18 16:08 liaxim

Looks pretty good overall.

liaxim avatar Aug 07 '18 17:08 liaxim

Needs rebase. Are any of the comments valid?

liaxim avatar Aug 13 '18 16:08 liaxim

Please generalize beyond stickers. This should be a component you attach to the Scene object that owns the render target to capture textures.

NolaDonato avatar Aug 13 '18 17:08 NolaDonato

@thomasflynn @NolaDonato In the current approach there is a way to set the interval at which the sticker(screenshot) needs to be captured. So if we move to RenderTarget based approach, onDrawFrame will be called every time. That means no interval but capturing every frame. Do we want interval for RenderTarget approach as well?

apjagdale avatar Aug 14 '18 18:08 apjagdale

Yes that would be useful. We should be able to specify it in terms of frames or seconds

NolaDonato avatar Aug 14 '18 20:08 NolaDonato

Should we close?

liaxim avatar Nov 28 '18 20:11 liaxim

We still want the feature but it can go into SXR instead of GVRF

NolaDonato avatar Nov 29 '18 22:11 NolaDonato