GearVRf icon indicating copy to clipboard operation
GearVRf copied to clipboard

GVRPickerInput continues to send onTouch events when disabled

Open SteveGreatApe opened this issue 7 years ago • 1 comments

I've just moved to 3.3.0 and switched my code to using GVRPickerInput. Currently I have one GVRPickerInput for the Eye Picker, plus a second one I switch to if I detect the Controller. When I switch to the controller picker I call onEnable(false) to disable the Eye Picker.

If I disable it while it has a non-null mPressedSceneObject then it continues to send onTouch events to this object every time I click the controller.

An onDisable() function in GVRPickerInput should fix it, with at the least setting mPressedSceneObject & mHoveredSceneObject to null. To help the application tidy up loose ends sendOnHoverExit() would also want to be called if mHoveredSceneObject was non-null, plus an ACTION_CANCEL event to mPressedSceneObject

SteveGreatApe avatar Oct 16 '17 12:10 SteveGreatApe

@SteveGreatApe Unfortunately the GVRPickerInput was something we had in the version under development. There have been improvements and GVRPicker should be used instead as of 3.3 release. I would be curious to know what your experience doing that is going to be.

@NolaDonato Please monitor this thread and provide assistance to @SteveGreatApe for this transition. I personally found out that it wasn't that straightforward but let's see what @SteveGreatApe thinks. Thanks.

liaxim avatar Oct 23 '17 21:10 liaxim