GearVRf icon indicating copy to clipboard operation
GearVRf copied to clipboard

Review the build configuration gradle properties

Open liaxim opened this issue 8 years ago • 6 comments

@rahul27 raised an issue that we have too many build configuration gradle properties. Should review and try to streamline these somehow. I am personally light on the details but there are number of use cases that have to be supported. The use of aars allows for a much more modular system and let's people download any prebuilt aars and just use them to build the demos. mavencentral works for the latest official fw version. Currently the mavencentral snapshots for master do not seem to be updated.

liaxim avatar Jan 04 '17 22:01 liaxim

@rahul27 Btw, do you have any suggestions about the configuration? I am unsure about implicit configuration (like checking if a folder exists then assuming one build or if it doesn't, assuming another).

liaxim avatar Mar 10 '17 16:03 liaxim

I don't have anything I am confident will be an improvement. I suggest we come back to this in the future.

liaxim avatar Mar 20 '17 20:03 liaxim

Fine with me. Can be addressed in the future.

rahul27 avatar Mar 20 '17 23:03 rahul27

if that's the case, it sounds like i can clear this of the 3.2 milestone. correct me if i'm wrong and i'll add it back.

thomasflynn avatar Mar 20 '17 23:03 thomasflynn

The only meaningful thing I came up with is to eliminate the option to build using local aars. We will have to ensure the automated build uploads snapshots daily.

Then the build would have two modes: if GearVRf-Demos is not in the same directory as GearVRf then use maven; if GearVRf is present then build everything together. This would eliminate useLocalDependencies and buildGvrfAndDemos.

And then have a backends property where requested backends would be enumerated instead of the current two-property thing.

It will be some improvement but I don't know..

liaxim avatar Mar 21 '17 14:03 liaxim

https://github.com/gearvrf/GearVRf-Demos/pull/446 removed the buildGvrfAndDemos option. Now this all happens automatically.

liaxim avatar May 03 '17 14:05 liaxim