samourai-wallet-android icon indicating copy to clipboard operation
samourai-wallet-android copied to clipboard

Pop toast for Ricochet fee

Open HeadyWook opened this issue 5 years ago • 0 comments

While fees for premium addons are publicly available around the internet (e.g., support.samourai.io/section/11-premium-transaction-fees), fees are no where to be found in the Samourai android app. Compared to experienced users (who may already be aware of the fee), novice users are left responsible to: Do the math (i.e., transaction total - send amount = ricochet fee) or leave the app for a Google fee search when reviewing a transaction. The explicit lack of fee information makes it easy for a user to approve a transaction while being unaware there was an added fee. This may result in a negative user experience.

This issue can be resolved by popping a toast message when the privacy addon Ricochet is selected. A benefit includes added transparency regarding fees for novice users. A risk is that experienced users might find it redundant. The fix can be applied by adding the following lines of code to the respective files:

  • File: strings.xml
  • Code: <string name="ricochet_fee">Ricochet Fee: 0.002 BTC</string>
  • Image:
  • image

and then,

  • File: SendActivity.java
  • Code: Toast.makeText(getApplicationContext(),R.string.ricochet_fee,Toast.LENGTH_SHORT).show();
  • Image:
  • image

By using this line of code in the strings.xml, maintenance for fee changes are more easily accessible than going 600+ lines of code into the SendActivity.java. By adding a pop toast fee message, transparency is increased and a negative user experience can be avoided. Also, the message is set to pop for a short length, mitigating the redundancy an experienced user may feel. Here is an example:

image

HeadyWook avatar Feb 16 '20 20:02 HeadyWook