samourai-wallet-android icon indicating copy to clipboard operation
samourai-wallet-android copied to clipboard

Published 20 hours ago • verified publisher icon Samourai-Wallet

Improve french translation and R.string usage

Open trackktor opened this issue 5 years ago • 2 comments

Hello, This patch improve french translation and also replace some strings with more generic R.string. I have tried to rgrep most of the strings. For example "enable/disable" should be gone. I have tested it with AVD manager and there is no obvious bug.

However, I added new empty lines in strings.xml. Sorry for that. If its really important I can clean it.

trackktor avatar Sep 15 '19 17:09 trackktor

Hello, This patch improve french translation and also replace some strings with more generic R.string. I have tried to rgrep most of the strings. For example "enable/disable" should be gone. I have tested it with AVD manager and there is no obvious bug.

However, I added new empty lines in strings.xml. Sorry for that. If its really important I can clean it.

Could you open a pull request to my fork of the repo with those changes so that I can do the same for the Bulgarian translation? I will translate the french strings. I just don't know how to replace the hard coded strings with ones from the file.

Relaxo143 avatar Oct 01 '19 14:10 Relaxo143

We are managing all French translations internally. Please resubmit w/only the R.string usage changes. Thank you.

SamouraiDev avatar Oct 15 '19 15:10 SamouraiDev