LaravelFacebookSdk icon indicating copy to clipboard operation
LaravelFacebookSdk copied to clipboard

Laravel 7 support

Open bbashel1 opened this issue 5 years ago • 7 comments
trafficstars

I added laravel 7 support in this fork if anyone wants to use. https://github.com/bbashel1/LaravelFacebookSdk

bbashel1 avatar May 14 '20 20:05 bbashel1

I do not see any changes to the code in your forked version of the package, what exactly did you changed?

Here, it`s in another branch: https://github.com/bbashel1/LaravelFacebookSdk/tree/laravel-7-support

Fuhrmann avatar Jul 01 '20 13:07 Fuhrmann

Awesome, thank you for the fork. How do I point to this specific fork from my composer.json?

Thus far I have:

"repositories": [ { "type": "vcs", "url": "https://github.com/s1rc/LaravelFacebookSdk" } ], "require": { "sammyk/laravel-facebook-sdk": "dev-s1rc:30" },

But that doesn't work. Any ideas?

MarcoTroost avatar Sep 02 '20 10:09 MarcoTroost

@MarcoTroost you need to add the 'name' to override the origin in your repository block.

  {
    "type": "vcs",
    "name":"sammyk/laravel-facebook-sdk",
    "url": "https://github.com/s1rc/LaravelFacebookSdk"
  }],
  "require": {
    "sammyk/laravel-facebook-sdk": "dev-s1rc:30"
  }

Otherwise, it will look at the origin for sammyk's package.

smartssa avatar Sep 04 '20 13:09 smartssa

@smartssa if I'll use this will there be any change in code or will anything break after this?

theamanjs avatar Nov 09 '20 17:11 theamanjs

I cannot confirm changes to code in this branch (it's not mine) - you can check the history. I forked my own from sammyk and only changed the dependency. No other code changes were needed for my own personal usage.

smartssa avatar Nov 09 '20 17:11 smartssa

Anyone looking to update this to Laravel 8? I use it in my package and was looking at updating.

geoff-maddock avatar Dec 18 '20 02:12 geoff-maddock

I updated my project to Laravel 8. And when upgrading, I didn't get any errors. It's strange and I It's working. Is this normal? Can someone explain me?

devinyasas avatar Jun 30 '21 06:06 devinyasas