Pavel Drankov

Results 31 comments of Pavel Drankov

@SunFeiyue , the source code for the `io.vertx.mqtt.impl.MqttClientImpl#handleClosed` is following: ```java void handleClosed() { synchronized (this) { boolean isConnected = this.isConnected; this.isConnected = false; if (!isConnected) { return; } }...

@SunFeiyue, I agree. I think the `isConnected` field should be changed only in the `handleClose` method.

@dushibaiyu , sorry, I did not get it. Which warning are you trying to fix? Can you explain?

@dushibaiyu , this PR also contains some parts from the https://github.com/vert-x3/vertx-mqtt/pull/101. Can you remove it, so the PR will contain only original changes?

@dushibaiyu , can you implement it in a way, as it done in the MQTT client, I mean deprecating `MqttServerOptions#setIdleTimeout` and delegating it to the `MqttServerOptions#setTimeoutOnConnect` call.

@dushibaiyu, can you try with the 3.6.0-SNAPSHOT version?

Ah, I see. You are right. We have already fixed the issue in the MQTT client. See the PR: https://github.com/vert-x3/vertx-mqtt/pull/79. I think we can do the same thing for MQTT...

I can work on that. But before we should discuss it. Let's start with a simple case: 1. The client was connected with a server and he just has some...

@ppatierno, what do you think about the #57 PR?