ngx-embed-video
ngx-embed-video copied to clipboard
SamirHodzic
Upgrading to Angular 8
I am trying to upgrade to Angular 8 but received the following warnings:
Package "ngx-embed-video" has an incompatible peer dependency to "@angular/common" (requires "^6.0.0" (extended), would install "8.0.0").
Package "ngx-embed-video" has an incompatible peer dependency to "@angular/core" (requires "^6.0.0" (extended), would install "8.0.0").
I would like to update to Angular 8 too and this holds me back for the moment.
@AdrianSima
You can get the service code from the repository.
Create your own project service for video embedding.
Fix what it needs for Angular 8 upgrading and continue working.
Can you please share the migration result? Any idea when the library will be compatible with Angular 8? @AdrianSima Can you please share your fix?
Is this still an actively supported project? I.e. would also love to see an "official" release to support Angular v8.
@Eraldo I've removed the package, updated Angular to latest, then re-added the package functionality as a Service by copying the code from src/embed-video-service.ts as suggested by Abdulrahmanh95
edit: If you want to keep it the same as the package, like a module, then you will also need the code from index.ts. Don't forget to update the paths to where you've created your service/module files.
The package has MIT license, so it shouldn't be any problem.
Do you mind doing this in the library itself and merging Adrian? That way we can keep getting updates and improvements down the road.
Remove the package, upgrade to Angular 8, readd the package. Works fine.
If anyone experiences an issue with Angular 8, imo the solution would be to create a pull-request here instead of creating yet another library. I would have done it myself, but the upgrade-process worked fine.
come on, guys, 5 contributors, used by 372 other packages, and no one is able to do a basic upgrade to the latest version of Angular, ^8.x.x? If this package is not actively supported anymore, please add a proper message saying it is discontinued. @SamirHodzic @lordoliver @hnipps @danconte72 @Nightbr
come on, guys, 5 contributors, used by 372 other packages, and no one is able to do a basic upgrade to the latest version of Angular, ^8.x.x? If this package is not actively supported anymore, please add a proper message saying it is discontinued.
do a fork, do the upgrade and submit a pull request
It's not a "job" like you call it because you don't pay us (or am I missing something?!).
Please refer to what a job is and what an Open Source Software is.
@Mallfurion It is a good package and very helpful. Are you planning to merge @Abdulrahmanh95 PR in the near future?
Simply remove the package out of your package.json and you can add it back in later after upgrading is completed. Hope it has helped.
