ChatBox icon indicating copy to clipboard operation
ChatBox copied to clipboard

fix: toast message after search and navigating to the chat page of the searched user

Open balaraju-nerati opened this issue 1 year ago • 11 comments

fixes #268

If searched user is new to the chat list - https://github.com/SamarthKadam/ChatBox/assets/90843128/f9712dd5-9568-4be3-a087-b30571a6c8c6

If searched user already added in the chat list - https://github.com/SamarthKadam/ChatBox/assets/90843128/1c7c54fd-fe64-40f1-a4a8-8c544890a4ff

balaraju-nerati avatar Jun 26 '24 05:06 balaraju-nerati

@balaraju-nerati is attempting to deploy a commit to the samarthkadam's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 26 '24 05:06 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chat-box-jyxx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 5:47am

vercel[bot] avatar Jun 26 '24 08:06 vercel[bot]

@Saigenix @Spiral-Memory Please review the code

SamarthKadam avatar Jun 26 '24 08:06 SamarthKadam

Hey @balaraju-nerati Code looks fine to me, could you please attach a video showing how it works !

Spiral-Memory avatar Jun 26 '24 08:06 Spiral-Memory

I already attached the working video @Spiral-Memory

balaraju-nerati avatar Jun 26 '24 08:06 balaraju-nerati

Got it, give me a minute !

Spiral-Memory avatar Jun 26 '24 08:06 Spiral-Memory

Hey, @Spiral-Memory Please check it now.

balaraju-nerati avatar Jun 26 '24 12:06 balaraju-nerati

LGTM ! Good work @balaraju-nerati

Spiral-Memory avatar Jun 27 '24 06:06 Spiral-Memory

https://github.com/SamarthKadam/ChatBox/assets/87573175/45e6a848-ad69-498b-afe3-c39d40a1a00f

I see there is broken design. Fix it. I recomend create a new fork and only make the functionality changes with clean code

SamarthKadam avatar Jun 28 '24 05:06 SamarthKadam

Hey @SamarthKadam , The design broken due the last commit I have made. Sry for that. Now, I removed the last commit. Everything works fine. Please check once.

balaraju-nerati avatar Jul 01 '24 13:07 balaraju-nerati

Hey, @SamarthKadam , Can you please look at this and merge the PR. 😃

balaraju-nerati avatar Jul 04 '24 16:07 balaraju-nerati