ChatBox icon indicating copy to clipboard operation
ChatBox copied to clipboard

Bug: Showing {Username} added in the search function even after {Username} has been added

Open balaraju-nerati opened this issue 1 year ago • 4 comments

When user searches for the X person who is already added, showing added X person.

https://github.com/SamarthKadam/ChatBox/assets/90843128/1740a338-d085-41fe-b607-bd673d64644f

Instead of showing the message, it should navigate to the chat of the person user searched.

@SamarthKadam I would like to work on this issue. Assign me this !

balaraju-nerati avatar Jun 11 '24 18:06 balaraju-nerati

Hey @balaraju-nerati

Looks like a good find ! I am assigning it to you, but before you raise your PR, kindly let me know your approach in fixing it.

Also let me know that whether you are a gssoc contributor ?

Spiral-Memory avatar Jun 12 '24 08:06 Spiral-Memory

@Spiral-Memory Thankyou for assigning the issue. Yes I'm a gssoc'24 contributor. Please add the level of the issue too.

My approach -

When the user clicks the X person which he searched, it'll redirect to the chat of the X person if the person is already added and I'll remove the toast message.

balaraju-nerati avatar Jun 12 '24 11:06 balaraju-nerati

Okay cool ! What about the user if they're not already added? If they're not, show a toast bar saying the user has been added like it is now and then redirect to his chat as well.

Spiral-Memory avatar Jun 12 '24 12:06 Spiral-Memory

Hey, @Spiral-Memory Can you check the PR I have raised

balaraju-nerati avatar Jun 26 '24 05:06 balaraju-nerati