Trovami icon indicating copy to clipboard operation
Trovami copied to clipboard

Check for existing group upon creation

Open Samaritan1011001 opened this issue 4 years ago • 9 comments

Check if a group with the same members already exist for the user. If present, do not create a new one.

Samaritan1011001 avatar Feb 15 '21 18:02 Samaritan1011001

Hmm. So if 9 of 10 are the same it's ok? Maybe this check is not necessary? Maybe user will eventually remove/delete members so they aren't identical. Should we second guess them? As long as only 1 group at a time is used, probably no harm in duplicate groups? As long as name/id is not the same

alankley avatar Feb 15 '21 18:02 alankley

Yes, but I was thinking we keep it simple in the beginning so it's easy for us to get the base app running. I feel once we have the basic group location sharing set up, we can add editing the group and it's members. It will just let us concentrate on the more important aspect of live location sharing without having to make it available for varying members of the group. We have plenty on our hands already and extra features must be considered after we have the base setup. What do you think?

On Mon, Feb 15, 2021 at 12:36 PM Alan Kleymeyer [email protected] wrote:

Hmm. So if 9 of 10 are the same it's ok? Maybe this check is not necessary? Maybe user will eventually remove/delete members so they aren't identical. Should we second guess them? As long as only 1 group at a time is used, probably no harm in duplicate groups? As long as name/id is not the same

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Samaritan1011001/Trovami/issues/30#issuecomment-779391947, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTP7Z2T6JJPKMTR7ZDDDATS7FSTXANCNFSM4XVEIEZQ .

Samaritan1011001 avatar Feb 15 '21 18:02 Samaritan1011001

But then again we would need to put work into checking if a group with the same members exists. So, I guess a duplicate group is less work. I'll put that card to backlog for now and take it up later.

On Mon, Feb 15, 2021 at 12:41 PM Manoj Bn [email protected] wrote:

Yes, but I was thinking we keep it simple in the beginning so it's easy for us to get the base app running. I feel once we have the basic group location sharing set up, we can add editing the group and it's members. It will just let us concentrate on the more important aspect of live location sharing without having to make it available for varying members of the group. We have plenty on our hands already and extra features must be considered after we have the base setup. What do you think?

On Mon, Feb 15, 2021 at 12:36 PM Alan Kleymeyer [email protected] wrote:

Hmm. So if 9 of 10 are the same it's ok? Maybe this check is not necessary? Maybe user will eventually remove/delete members so they aren't identical. Should we second guess them? As long as only 1 group at a time is used, probably no harm in duplicate groups? As long as name/id is not the same

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Samaritan1011001/Trovami/issues/30#issuecomment-779391947, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTP7Z2T6JJPKMTR7ZDDDATS7FSTXANCNFSM4XVEIEZQ .

Samaritan1011001 avatar Feb 15 '21 18:02 Samaritan1011001

Editing the group is not currently supported? I would think this is very basic to support from the beginning. Groups with duplicate members don't do any harm. Adding checks to check for identical members is adding code. Adding the check, however, is a small issue. I don't think it's necessary but I don't feel strongly about it.

alankley avatar Feb 15 '21 18:02 alankley

Haha yeah, I realized. Let's go with duplicates. Do you want to move these conversations to slack?

On Mon, Feb 15, 2021 at 12:44 PM Alan Kleymeyer [email protected] wrote:

Editing the group is not currently supported? I would think this is very basic to support from the beginning. Duplicate groups don't do any harm. Adding checks to check for identical members is adding code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Samaritan1011001/Trovami/issues/30#issuecomment-779394850, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTP7ZYIOHRWJZ3QSSOSJ6TS7FTSVANCNFSM4XVEIEZQ .

Samaritan1011001 avatar Feb 15 '21 18:02 Samaritan1011001

Hey Alan,

I added cards that I think we can start with. The cards under "To Do" are in order of priority that I think we need to use. If you have other thoughts, happy to discuss. The ones in "Backlog" are the ones I feel we can consider at a later date when we have the base app refactored and running. Let me know what you think. Also, consider moving our conversations to slack or other instant messaging platforms. It's just quicker and easier to communicate. Thanks.

On Mon, Feb 15, 2021 at 12:46 PM Manoj Bn [email protected] wrote:

Haha yeah, I realized. Let's go with duplicates. Do you want to move these conversations to slack?

On Mon, Feb 15, 2021 at 12:44 PM Alan Kleymeyer [email protected] wrote:

Editing the group is not currently supported? I would think this is very basic to support from the beginning. Duplicate groups don't do any harm. Adding checks to check for identical members is adding code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Samaritan1011001/Trovami/issues/30#issuecomment-779394850, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTP7ZYIOHRWJZ3QSSOSJ6TS7FTSVANCNFSM4XVEIEZQ .

Samaritan1011001 avatar Feb 15 '21 19:02 Samaritan1011001

I agree. I suggested the same on a previous email. I have 2 different company Slack accounts. I just created a new Slack account using [email protected] if you use Slack.

On Mon, Feb 15, 2021 at 1:10 PM ManojNB [email protected] wrote:

Hey Alan,

I added cards that I think we can start with. The cards under "To Do" are in order of priority that I think we need to use. If you have other thoughts, happy to discuss. The ones in "Backlog" are the ones I feel we can consider at a later date when we have the base app refactored and running. Let me know what you think. Also, consider moving our conversations to slack or other instant messaging platforms. It's just quicker and easier to communicate. Thanks.

On Mon, Feb 15, 2021 at 12:46 PM Manoj Bn [email protected] wrote:

Haha yeah, I realized. Let's go with duplicates. Do you want to move these conversations to slack?

On Mon, Feb 15, 2021 at 12:44 PM Alan Kleymeyer < [email protected]> wrote:

Editing the group is not currently supported? I would think this is very basic to support from the beginning. Duplicate groups don't do any harm. Adding checks to check for identical members is adding code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/Samaritan1011001/Trovami/issues/30#issuecomment-779394850 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACTP7ZYIOHRWJZ3QSSOSJ6TS7FTSVANCNFSM4XVEIEZQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Samaritan1011001/Trovami/issues/30#issuecomment-779404735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ44WSO67BBW77NYWBXTH3S7FWTNANCNFSM4XVEIEZQ .

alankley avatar Feb 15 '21 20:02 alankley

I tried chatting through Gmail and it took me to Hangouts which is going away. Do you use Slack? I couldn't find a Free version. I have 2 company accounts with Slack.

I also use GroupMe Chat app

On Mon, Feb 15, 2021 at 2:01 PM Alan [email protected] wrote:

I agree. I suggested the same on a previous email. I have 2 different company Slack accounts. I just created a new Slack account using [email protected] if you use Slack.

On Mon, Feb 15, 2021 at 1:10 PM ManojNB [email protected] wrote:

Hey Alan,

I added cards that I think we can start with. The cards under "To Do" are in order of priority that I think we need to use. If you have other thoughts, happy to discuss. The ones in "Backlog" are the ones I feel we can consider at a later date when we have the base app refactored and running. Let me know what you think. Also, consider moving our conversations to slack or other instant messaging platforms. It's just quicker and easier to communicate. Thanks.

On Mon, Feb 15, 2021 at 12:46 PM Manoj Bn [email protected] wrote:

Haha yeah, I realized. Let's go with duplicates. Do you want to move these conversations to slack?

On Mon, Feb 15, 2021 at 12:44 PM Alan Kleymeyer < [email protected]> wrote:

Editing the group is not currently supported? I would think this is very basic to support from the beginning. Duplicate groups don't do any harm. Adding checks to check for identical members is adding code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/Samaritan1011001/Trovami/issues/30#issuecomment-779394850 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACTP7ZYIOHRWJZ3QSSOSJ6TS7FTSVANCNFSM4XVEIEZQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Samaritan1011001/Trovami/issues/30#issuecomment-779404735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ44WSO67BBW77NYWBXTH3S7FWTNANCNFSM4XVEIEZQ .

alankley avatar Feb 15 '21 20:02 alankley

Hi Alan, I just created a slack workspace for trovami and added you. There is a free Slack version. You should be able to log in to the workspace from the invite I sent you.

On Mon, Feb 15, 2021 at 2:13 PM Alan Kleymeyer [email protected] wrote:

I tried chatting through Gmail and it took me to Hangouts which is going away. Do you use Slack? I couldn't find a Free version. I have 2 company accounts with Slack.

I also use GroupMe Chat app

On Mon, Feb 15, 2021 at 2:01 PM Alan [email protected] wrote:

I agree. I suggested the same on a previous email. I have 2 different company Slack accounts. I just created a new Slack account using [email protected] if you use Slack.

On Mon, Feb 15, 2021 at 1:10 PM ManojNB [email protected] wrote:

Hey Alan,

I added cards that I think we can start with. The cards under "To Do" are in order of priority that I think we need to use. If you have other thoughts, happy to discuss. The ones in "Backlog" are the ones I feel we can consider at a later date when we have the base app refactored and running. Let me know what you think. Also, consider moving our conversations to slack or other instant messaging platforms. It's just quicker and easier to communicate. Thanks.

On Mon, Feb 15, 2021 at 12:46 PM Manoj Bn [email protected] wrote:

Haha yeah, I realized. Let's go with duplicates. Do you want to move these conversations to slack?

On Mon, Feb 15, 2021 at 12:44 PM Alan Kleymeyer < [email protected]> wrote:

Editing the group is not currently supported? I would think this is very basic to support from the beginning. Duplicate groups don't do any harm. Adding checks to check for identical members is adding code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/Samaritan1011001/Trovami/issues/30#issuecomment-779394850

,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACTP7ZYIOHRWJZ3QSSOSJ6TS7FTSVANCNFSM4XVEIEZQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/Samaritan1011001/Trovami/issues/30#issuecomment-779404735 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAJ44WSO67BBW77NYWBXTH3S7FWTNANCNFSM4XVEIEZQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Samaritan1011001/Trovami/issues/30#issuecomment-779428379, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTP7Z7ZIFEC5EPMBUVLXT3S7F57NANCNFSM4XVEIEZQ .

Samaritan1011001 avatar Feb 15 '21 21:02 Samaritan1011001