react-map-gl-geocoder icon indicating copy to clipboard operation
react-map-gl-geocoder copied to clipboard

react-map-gl 7 support

Open dannyskoog opened this issue 3 years ago • 7 comments

I'm currently int the process of updating react-map-gl to version 7 but get compilation errors (originating from react-map-gl-geocoder) saying:

Attempted import error: 'FlyToInterpolator' is not exported from 'react-map-gl' (imported as 'r').

And FlyToInterpolator seems to have been removed (https://visgl.github.io/react-map-gl/docs/upgrade-guide#upgrading-to-v70). Are there any plans of supporting version 7?

dannyskoog avatar Feb 08 '22 00:02 dannyskoog

Sorry, no plans. It's possible that I'll do it at some point, but it probably won't be anytime soon. I usually suggest people just copy pasta the code and modify it for their needs especially since I don't really work on this project anymore. https://github.com/SamSamskies/react-map-gl-geocoder/blob/master/src/index.js

SamSamskies avatar Feb 08 '22 02:02 SamSamskies

I understand. Well, thanks for the quick and informative answer. Appreciate it!

dannyskoog avatar Feb 08 '22 11:02 dannyskoog

hi everyone, what is the solution here? Does downgrading just react-map-gl help or do I need to downgrade both react-map-gl and react-map-gl-geocoder? Many thanks much appreciated!

FrancescoBurchielli avatar May 18 '22 14:05 FrancescoBurchielli

hi everyone, what is the solution here? Does downgrading just react-map-gl help or do I need to downgrade both react-map-gl and react-map-gl-geocoder? Many thanks much appreciated!

just React-Map-GL

bhison avatar Jun 08 '22 11:06 bhison

Haven't tried it yet myself, but just noticed that the release notes say that you don't need a react wrapper for geocoder any more.

https://visgl.github.io/react-map-gl/docs/whats-new#react-map-gl-v70

Compatibility: first and third-party plugins! Directly use mapbox-gl-draw, mapbox-gl-geocoder, to name a few.

joelugh avatar Jun 12 '22 12:06 joelugh

good advice @joelugh

Another option is to recreate the react-map-gl v7 geocoder example

bhison avatar Jun 13 '22 12:06 bhison

Haven't tried it yet myself, but just noticed that the release notes say that you don't need a react wrapper for geocoder any more.

https://visgl.github.io/react-map-gl/docs/whats-new#react-map-gl-v70

Compatibility: first and third-party plugins! Directly use mapbox-gl-draw, mapbox-gl-geocoder, to name a few.

Hey @joelugh, did you end up trying this?

stephenavocado avatar Aug 21 '22 12:08 stephenavocado