fast_blank icon indicating copy to clipboard operation
fast_blank copied to clipboard

Adopt the latest implementation for String#blank? from ActiveSupport and update benchmark result

Open ken3ypa opened this issue 1 year ago • 2 comments

Diffs

  • Adopted the latest implementation for String#blank? from ActiveSupport. (ref)
  • Update the benchmark to reflect the latest implementation.

I noticed a minor diffs between the latest code in ActiveSupport and benchmarking code in this gem. After updating, the performance difference appears to be smaller; still this gem remains faster.

Thanks for making this gem. I really like this gem.

ken3ypa avatar Aug 12 '23 01:08 ken3ypa

I noticed same thing and was going to do similar PR.

I see about a ~1x to ~3x diff locally in benchmark. Still noticeable, but smaller than the ~10+ year old versions of ruby/rails this first worked on.

Also noticed the ruby versions listed in the README are pretty out of date ... might be worth a once over on the ruby/rails versions supported to assist anyone arriving here with an "is this still relevant, given perf improvements in ruby/rails?" sort of question.

mjankowski avatar Jun 12 '24 18:06 mjankowski

Hi there! Is this still relevant, given perf improvements in ruby/rails? 😝 (I'm running Rails 7.2 and Ruby 3.3.4)

Thank you!

n-rodriguez avatar Aug 16 '24 00:08 n-rodriguez